search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
719 stars 243 forks source link

fix: wakuv2 failing tests #5444

Closed chaitanyaprem closed 2 days ago

chaitanyaprem commented 3 days ago

Closes #5439

status-im-auto commented 3 days ago

Jenkins Builds

Click to see older builds (4) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | d81a1805 | [#1](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5444/1/) | 2024-06-28 13:09:20 | ~4 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240628-130441-d81a18-pr5444.zip) | | :heavy_check_mark: | d81a1805 | [#1](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5444/1/) | 2024-06-28 13:11:40 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240628-130441-d81a18-pr5444.aar) | | :heavy_check_mark: | d81a1805 | [#1](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5444/1/) | 2024-06-28 13:12:19 | ~7 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240628-130446-d81a18-pr5444.zip) | | :heavy_multiplication_x: | d81a1805 | [#1](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5444/1/) | 2024-06-28 13:15:07 | ~10 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5444/1//consoleText) |
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 3313cbf2 #2 2024-06-28 16:03:11 ~2 min linux :package:zip
:heavy_multiplication_x: 3313cbf2 #2 2024-06-28 16:03:28 ~2 min tests :page_facing_up:log
:heavy_check_mark: 3313cbf2 #2 2024-06-28 16:05:13 ~4 min ios :package:zip
:heavy_check_mark: 3313cbf2 #2 2024-06-28 16:06:34 ~5 min android :package:aar
:heavy_check_mark: 8f37d50f #3 2024-06-28 16:08:16 ~2 min linux :package:zip
:heavy_check_mark: 8f37d50f #3 2024-06-28 16:08:28 ~2 min ios :package:zip
:heavy_check_mark: 8f37d50f #3 2024-06-28 16:08:41 ~1 min android :package:aar
:heavy_check_mark: 8f37d50f #3 2024-06-28 16:51:53 ~45 min tests :page_facing_up:log
chaitanyaprem commented 2 days ago

Thanks for a quick fix! Looks like one of the tests is fixed, but the other one still feels bad 😢

image

Oh, this has passed locally. Odd that it failed here.

chaitanyaprem commented 2 days ago

Added some randomness in contentTopic used and removed peerExchangeClient config so that test uses only fleet nodes. This should make it non-flaky. Ran 10 times locally and no failures noticed.