search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
728 stars 246 forks source link

fix_: panic when enr exceeds 300 bytes #5446

Closed richard-ramos closed 2 months ago

richard-ramos commented 3 months ago

Fixes an issue described in https://github.com/waku-org/go-waku/issues/1138

panic: enode: can't sign record: record bigger than 300 bytes

goroutine 2234124 [running]:
github.com/ethereum/go-ethereum/p2p/enode.(*LocalNode).sign(0x2400110e000)
    /Users/prem/Code/status-desktop/vendor/status-go/vendor/github.com/ethereum/go-ethereum/p2p/enode/localnode.go:310 +0x41c
github.com/ethereum/go-ethereum/p2p/enode.(*LocalNode).Node(0x2400110e000)
    /Users/prem/Code/status-desktop/vendor/status-go/vendor/github.com/ethereum/go-ethereum/p2p/enode/localnode.go:122 +0x158
github.com/waku-org/go-discover/discover.(*UDPv5).Self(...)
    /Users/prem/Code/status-desktop/vendor/status-go/vendor/github.com/waku-org/go-discover/discover/v5_udp.go:178
github.com/waku-org/go-discover/discover.(*UDPv5).lookupWorker(0x24003a69d00, 0x2400a81f050, {0x49, 0xc9, 0xc, 0x7b, 0x44, 0x98, 0x4c, 0x96, ...})
    /Users/prem/Code/status-desktop/vendor/status-go/vendor/github.com/waku-org/go-discover/discover/v5_udp.go:313 +0x154
github.com/waku-org/go-discover/discover.(*UDPv5).lookupSelf.(*UDPv5).newLookup.func1(0x45fe71fd67876148?)
    /Users/prem/Code/status-desktop/vendor/status-go/vendor/github.com/waku-org/go-discover/discover/v5_udp.go:296 +0x38
github.com/waku-org/go-discover/discover.(*lookup).query(0x2400e4d5ef0, 0x2400a81f050, 0x240061d4380?)
    /Users/prem/Code/status-desktop/vendor/status-go/vendor/github.com/waku-org/go-discover/discover/lookup.go:144 +0x98
created by github.com/waku-org/go-discover/discover.(*lookup).startQueries in goroutine 546
    /Users/prem/Code/status-desktop/vendor/status-go/vendor/github.com/waku-org/go-discover/discover/lookup.go:126 +0x1d4
SIGABRT: Abnormal termination.
make: *** [run-macos] Abort trap: 6
status-im-auto commented 3 months ago

Jenkins Builds

:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 7113d198 #1 2024-06-28 15:14:02 ~3 min linux :package:zip
:heavy_check_mark: 7113d198 #1 2024-06-28 15:14:49 ~4 min ios :package:zip
:heavy_check_mark: 7113d198 #1 2024-06-28 15:15:51 ~5 min android :package:aar
:heavy_check_mark: 7113d198 #1 2024-06-28 15:53:44 ~43 min tests :page_facing_up:log