search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
719 stars 243 forks source link

fix_: fix swap in routerV2 #5447

Closed dlipicar closed 3 hours ago

dlipicar commented 2 days ago

Part of #15095

Sending Swap transactions was broken due to changes in this PR.

A map was introduced which requires the from/to token symbols to form the key, which wasn't available when sending the Tx. We fix that here.

status-im-auto commented 2 days ago

Jenkins Builds

Click to see older builds (11) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | 7d4170a8 | [#1](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5447/1/) | 2024-06-28 22:22:28 | ~4 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240628-221818-7d4170-pr5447.zip) | | :heavy_check_mark: | 7d4170a8 | [#1](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5447/1/) | 2024-06-28 22:22:55 | ~4 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240628-221818-7d4170-pr5447.zip) | | :heavy_check_mark: | 7d4170a8 | [#1](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5447/1/) | 2024-06-28 22:24:19 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240628-221818-7d4170-pr5447.aar) | | :heavy_check_mark: | 7d4170a8 | [#1](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5447/1/) | 2024-06-28 23:02:59 | ~44 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5447/1//consoleText) | | | | | | | | | | :heavy_check_mark: | 35b8874f | [#2](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5447/2/) | 2024-06-30 17:34:05 | ~1 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240630-173227-35b887-pr5447.aar) | | :heavy_check_mark: | 35b8874f | [#2](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5447/2/) | 2024-06-30 17:34:32 | ~2 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240630-173231-35b887-pr5447.zip) | | :heavy_check_mark: | 35b8874f | [#2](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5447/2/) | 2024-06-30 17:35:00 | ~2 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240630-173227-35b887-pr5447.zip) | | :heavy_check_mark: | 35b8874f | [#2](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5447/2/) | 2024-06-30 18:15:58 | ~43 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5447/2//consoleText) | | | | | | | | | | :heavy_check_mark: | eb065b99 | [#3](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5447/3/) | 2024-06-30 17:52:11 | ~2 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240630-174952-eb065b-pr5447.aar) | | :heavy_check_mark: | eb065b99 | [#3](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5447/3/) | 2024-06-30 17:52:12 | ~2 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240630-174952-eb065b-pr5447.zip) | | :heavy_check_mark: | eb065b99 | [#3](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5447/3/) | 2024-06-30 17:52:37 | ~2 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240630-174952-eb065b-pr5447.zip) |
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 14ca0537 #4 2024-06-30 18:14:45 ~2 min linux :package:zip
:heavy_check_mark: 14ca0537 #4 2024-06-30 18:14:47 ~2 min android :package:aar
:heavy_check_mark: 14ca0537 #4 2024-06-30 18:14:54 ~2 min ios :package:zip
:heavy_check_mark: 14ca0537 #3 2024-06-30 18:59:18 ~43 min tests :page_facing_up:log
:heavy_check_mark: f0fb7da3 #5 2024-06-30 21:41:25 ~2 min android :package:aar
:heavy_check_mark: f0fb7da3 #5 2024-06-30 21:41:26 ~2 min linux :package:zip
:heavy_check_mark: f0fb7da3 #5 2024-06-30 21:41:32 ~2 min ios :package:zip
:heavy_multiplication_x: f0fb7da3 #4 2024-06-30 21:44:03 ~5 min tests :page_facing_up:log
:heavy_multiplication_x: f0fb7da3 #5 2024-06-30 21:50:59 ~4 min tests :page_facing_up:log
:heavy_check_mark: f0fb7da3 #6 2024-06-30 22:47:12 ~44 min tests :page_facing_up:log
dlipicar commented 20 hours ago

@saledjenic reverted the changes in the struct