search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
726 stars 246 forks source link

The same admin events are adding to the community description #5771

Open mprakhov opened 9 months ago

mprakhov commented 9 months ago

Bug Report

Description

msg 1: Admin A sends event 1 msg 2: Admin B sends event 2

The control node receives msg 1, accepts it, and updates communityDescription clock The control node receives msg 2 and declines it due to the clock.

both admins (A and B) get ApplicationMetadataMessage_COMMUNITY_EVENTS_MESSAGE_REJECTED and resend their events. Admin A event 1 will be sent twice to the control node.

Another problem is that events will be sent not in order, because each member resend only their own events

Expectation

We need to decide what to do:

  1. If the CommunityDescription clock is changed - drop all other events
  2. Handle all events and do not send already applied events to the CommunityDescription
iurimatias commented 8 months ago

moved to 2.29 due to lack of space in this milestone