search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
727 stars 247 forks source link

chore_: use zap logger as request logger #5991

Closed osmaczko closed 4 weeks ago

osmaczko commented 1 month ago

iterates: status-im/status-go#6002

status-im-auto commented 1 month ago

Jenkins Builds

Click to see older builds (21) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_multiplication_x: | 0f2acbb5 | [#1](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5991/1/) | 2024-10-24 21:52:32 | ~3 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5991/1//consoleText) | | :heavy_check_mark: | 0f2acbb5 | [#1](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-5991/1/) | 2024-10-24 21:54:04 | ~5 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241024-214838-0f2acb-pr5991.zip) | | :heavy_check_mark: | 0f2acbb5 | [#1](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5991/1/) | 2024-10-24 21:54:10 | ~5 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241024-214836-0f2acb-pr5991.zip) | | :heavy_check_mark: | 0f2acbb5 | [#1](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5991/1/) | 2024-10-24 21:55:06 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-241024-214835-0f2acb-pr5991.aar) | | :heavy_check_mark: | 0f2acbb5 | [#1](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-5991/1/) | 2024-10-24 21:55:33 | ~6 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-5991/1//consoleText) | | | | | | | | | | :heavy_multiplication_x: | e1058dff | [#2](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5991/2/) | 2024-10-24 21:54:57 | ~2 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5991/2//consoleText) | | :heavy_check_mark: | e1058dff | [#2](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5991/2/) | 2024-10-24 21:59:16 | ~5 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241024-215415-e1058d-pr5991.zip) | | :heavy_check_mark: | e1058dff | [#2](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-5991/2/) | 2024-10-24 21:59:22 | ~5 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241024-215408-e1058d-pr5991.zip) | | :heavy_check_mark: | e1058dff | [#2](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5991/2/) | 2024-10-24 22:01:31 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-241024-215511-e1058d-pr5991.aar) | | :heavy_check_mark: | e1058dff | [#2](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-5991/2/) | 2024-10-24 22:01:52 | ~6 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-5991/2//consoleText) | | | | | | | | | | :heavy_check_mark: | e4dcd148 | [#3](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-5991/3/) | 2024-10-25 06:44:00 | ~5 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241025-063856-e4dcd1-pr5991.zip) | | :heavy_check_mark: | e4dcd148 | [#3](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5991/3/) | 2024-10-25 06:44:14 | ~5 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241025-063855-e4dcd1-pr5991.zip) | | :heavy_check_mark: | e4dcd148 | [#3](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5991/3/) | 2024-10-25 06:45:11 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-241025-063854-e4dcd1-pr5991.aar) | | :heavy_multiplication_x: | e4dcd148 | [#3](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-5991/3/) | 2024-10-25 06:45:30 | ~6 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-5991/3//consoleText) | | :heavy_check_mark: | e4dcd148 | [#3](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5991/3/) | 2024-10-25 07:13:17 | ~34 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5991/3//consoleText) | | | | | | | | | | :heavy_multiplication_x: | c2d5c238 | [#4](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5991/4/) | 2024-10-25 09:43:13 | ~1 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5991/4//consoleText) | | :heavy_check_mark: | c2d5c238 | [#4](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5991/4/) | 2024-10-25 09:46:45 | ~5 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241025-094127-c2d5c2-pr5991.zip) | | :heavy_check_mark: | c2d5c238 | [#4](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-5991/4/) | 2024-10-25 09:46:52 | ~5 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241025-094129-c2d5c2-pr5991.zip) | | :heavy_check_mark: | c2d5c238 | [#4](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-5991/4/) | 2024-10-25 09:47:45 | ~6 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-5991/4//consoleText) | | :heavy_check_mark: | c2d5c238 | [#4](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5991/4/) | 2024-10-25 09:47:51 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-241025-094126-c2d5c2-pr5991.aar) | | :heavy_multiplication_x: | c2d5c238 | [#5](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5991/5/) | 2024-10-25 11:24:43 | ~1 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5991/5//consoleText) |
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 54fdf505 #5 2024-10-28 10:13:44 ~5 min linux :package:zip
:heavy_check_mark: 54fdf505 #5 2024-10-28 10:13:54 ~5 min ios :package:zip
:heavy_check_mark: 54fdf505 #5 2024-10-28 10:14:21 ~5 min tests-rpc :page_facing_up:log
:heavy_check_mark: 54fdf505 #5 2024-10-28 10:14:35 ~5 min android :package:aar
:heavy_check_mark: 54fdf505 #6 2024-10-28 10:41:25 ~32 min tests :page_facing_up:log
:heavy_check_mark: 54fdf505 #6 2024-10-28 21:00:05 ~5 min linux :package:zip
:heavy_check_mark: 54fdf505 #6 2024-10-28 21:00:38 ~6 min ios :package:zip
:heavy_check_mark: 54fdf505 #6 2024-10-28 21:00:55 ~6 min tests-rpc :page_facing_up:log
:heavy_check_mark: 54fdf505 #6 2024-10-28 21:01:03 ~6 min android :package:aar
:heavy_check_mark: 54fdf505 #7 2024-10-28 21:28:27 ~33 min tests :page_facing_up:log
:heavy_check_mark: 2205723d #1 2024-10-28 21:04:29 ~6 min macos :package:zip
:heavy_check_mark: 2205723d #7 2024-10-28 21:05:47 ~5 min linux :package:zip
:heavy_check_mark: 2205723d #1 2024-10-28 21:06:31 ~8 min macos :package:zip
:heavy_check_mark: 2205723d #7 2024-10-28 21:07:15 ~6 min tests-rpc :page_facing_up:log
:heavy_check_mark: 2205723d #7 2024-10-28 21:07:23 ~6 min ios :package:zip
:heavy_check_mark: 2205723d #7 2024-10-28 21:07:37 ~6 min android :package:aar
:heavy_multiplication_x: 2205723d #1 2024-10-28 21:08:42 ~10 min windows :package:zip
:heavy_check_mark: 2205723d #8 2024-10-28 22:02:38 ~34 min tests :page_facing_up:log
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.47%. Comparing base (2ced83a) to head (2205723). Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
logutils/requestlog/request_log.go 83.33% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5991 +/- ## =========================================== - Coverage 47.50% 47.47% -0.04% =========================================== Files 850 850 Lines 139515 139522 +7 =========================================== - Hits 66275 66236 -39 - Misses 65450 65484 +34 - Partials 7790 7802 +12 ``` | [Flag](https://app.codecov.io/gh/status-im/status-go/pull/5991/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [functional](https://app.codecov.io/gh/status-im/status-go/pull/5991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `10.17% <0.00%> (-0.06%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/status-im/status-go/pull/5991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `46.96% <92.85%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/status-im/status-go/pull/5991?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [logutils/logrotation.go](https://app.codecov.io/gh/status-im/status-go/pull/5991?src=pr&el=tree&filepath=logutils%2Flogrotation.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-bG9ndXRpbHMvbG9ncm90YXRpb24uZ28=) | `100.00% <100.00%> (ø)` | | | [mobile/status\_request\_log.go](https://app.codecov.io/gh/status-im/status-go/pull/5991?src=pr&el=tree&filepath=mobile%2Fstatus_request_log.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-bW9iaWxlL3N0YXR1c19yZXF1ZXN0X2xvZy5nbw==) | `91.66% <100.00%> (+1.19%)` | :arrow_up: | | [logutils/requestlog/request\_log.go](https://app.codecov.io/gh/status-im/status-go/pull/5991?src=pr&el=tree&filepath=logutils%2Frequestlog%2Frequest_log.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-bG9ndXRpbHMvcmVxdWVzdGxvZy9yZXF1ZXN0X2xvZy5nbw==) | `89.47% <83.33%> (+5.47%)` | :arrow_up: | ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/status-im/status-go/pull/5991/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im)