search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
727 stars 247 forks source link

feat: dial, drop and retrieve connected peers #5994

Closed gabrielmer closed 3 weeks ago

gabrielmer commented 4 weeks ago

Integrating and implementing features to dial, drop and retrieve connected peers.

Important changes:

This PR depends on the new libwaku procedures exposed in https://github.com/waku-org/nwaku/pull/3149 Once the nwaku PR is merged, I will update the nwaku submodule in this PR

Issue: https://github.com/waku-org/nwaku/issues/3076

github-actions[bot] commented 4 weeks ago

We require commits to follow the Conventional Commits, but with _ for non-breaking changes. Please fix these commit messages:

implementing feedback
fix flaky test
integrating waku_get_connected_peers and fixing test
changing function name to specify that only connected relay peers are returned
initial dialPeer implementation
implementing PeerCount and DropPeer
status-im-auto commented 4 weeks ago

Jenkins Builds

Click to see older builds (5) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_multiplication_x: | d7290d48 | [#1](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5994/1/) | 2024-10-28 10:48:20 | ~1 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5994/1//consoleText) | | :heavy_check_mark: | d7290d48 | [#1](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5994/1/) | 2024-10-28 10:51:12 | ~4 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241028-104617-d7290d-pr5994.zip) | | :heavy_check_mark: | d7290d48 | [#1](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-5994/1/) | 2024-10-28 10:51:31 | ~5 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241028-104621-d7290d-pr5994.zip) | | :heavy_check_mark: | d7290d48 | [#1](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-5994/1/) | 2024-10-28 10:51:49 | ~5 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-5994/1//consoleText) | | :heavy_check_mark: | d7290d48 | [#1](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5994/1/) | 2024-10-28 10:52:39 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-241028-104616-d7290d-pr5994.aar) |
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_multiplication_x: e1ab9d37 #2 2024-10-28 11:45:12 ~1 min tests :page_facing_up:log
:heavy_check_mark: e1ab9d37 #2 2024-10-28 11:45:38 ~2 min android :package:aar
:heavy_check_mark: e1ab9d37 #2 2024-10-28 11:46:12 ~2 min linux :package:zip
:heavy_check_mark: e1ab9d37 #2 2024-10-28 11:46:49 ~3 min ios :package:zip
:heavy_check_mark: e1ab9d37 #2 2024-10-28 11:49:12 ~5 min tests-rpc :page_facing_up:log
:heavy_multiplication_x: a87b625c #3 2024-10-28 15:51:48 ~1 min tests :page_facing_up:log
:heavy_check_mark: a87b625c #3 2024-10-28 15:52:24 ~2 min android :package:aar
:heavy_check_mark: a87b625c #3 2024-10-28 15:52:48 ~2 min linux :package:zip
:heavy_check_mark: a87b625c #3 2024-10-28 15:53:25 ~3 min ios :package:zip
:heavy_multiplication_x: a87b625c #3 2024-10-28 15:55:55 ~5 min tests-rpc :page_facing_up:log
codecov[bot] commented 4 weeks ago

:x: 1 Tests Failed:

Tests completed Failed Passed Skipped
23 1 22 0
View the top 1 failed tests by shortest run time > > ``` > tests.test_router.TestTransactionFromRoute test_tx_from_route > ``` > >
Stack Traces | 10.6s run time > > > > > ``` > > tests/test_router.py:114: in test_tx_from_route > > assert tx_details["to"] == user_2.address > > E AssertionError: assert '0x70997970C5...50e0d17dc79C8' == '0x70997970c5...50e0d17dc79c8' > > E - 0x70997970c51812dc3a010c7d01b50e0d17dc79c8 > > E ? ^ ^ ^ ^ > > E + 0x70997970C51812dc3A010C7d01b50e0d17dc79C8 > > E ? ^ ^ ^ ^ > > ``` > >

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

gabrielmer commented 3 weeks ago

Closing this PR in favor of https://github.com/status-im/status-go/pull/6013 , as there are big conflicts with the base branch