search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
727 stars 247 forks source link

chore: integrate on-demand DNS discovery and implement discoverAndConnectPeers #6000

Closed gabrielmer closed 3 weeks ago

gabrielmer commented 4 weeks ago

Integrating libwaku's on-demand DNS discovery functionality and implementing discoverAndConnectPeers

Notice that for discoverAndConnectPeers, we have to do it sequentially and not with goroutines, as libwaku doesn't work properly with goroutines for now (because of goroutines spinning up multiple threads and Nim being set up only in one).

This PR will work properly once https://github.com/waku-org/nwaku/pull/3155 is merged, will update the nwaku submodule here once the fix is in master

Important changes:

Issue https://github.com/waku-org/nwaku/issues/3076

github-actions[bot] commented 4 weeks ago

We require commits to follow the Conventional Commits, but with _ for non-breaking changes. Please fix these commit messages:

implement discoverandConnectPeers
adding dns discovery test
test test
initial dns discovery integration
status-im-auto commented 4 weeks ago

Jenkins Builds

:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_multiplication_x: 3a03c446 #1 2024-10-28 16:43:08 ~1 min tests :page_facing_up:log
:heavy_check_mark: 3a03c446 #1 2024-10-28 16:46:18 ~4 min ios :package:zip
:heavy_check_mark: 3a03c446 #1 2024-10-28 16:46:31 ~5 min linux :package:zip
:heavy_check_mark: 3a03c446 #1 2024-10-28 16:46:47 ~5 min android :package:aar
:heavy_multiplication_x: 3a03c446 #1 2024-10-28 16:48:07 ~6 min tests-rpc :page_facing_up:log
codecov[bot] commented 4 weeks ago

:x: 1 Tests Failed:

Tests completed Failed Passed Skipped
23 1 22 0
View the top 1 failed tests by shortest run time > > ``` > tests.test_router.TestTransactionFromRoute test_tx_from_route > ``` > >
Stack Traces | 10.6s run time > > > > > ``` > > tests/test_router.py:114: in test_tx_from_route > > assert tx_details["to"] == user_2.address > > E AssertionError: assert '0x70997970C5...50e0d17dc79C8' == '0x70997970c5...50e0d17dc79c8' > > E - 0x70997970c51812dc3a010c7d01b50e0d17dc79c8 > > E ? ^ ^ ^ ^ > > E + 0x70997970C51812dc3A010C7d01b50e0d17dc79C8 > > E ? ^ ^ ^ ^ > > ``` > >

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

gabrielmer commented 3 weeks ago

Closing this PR in favor of https://github.com/status-im/status-go/pull/6017