search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
728 stars 247 forks source link

chore_: get version with go generate #6014

Closed igor-sirotin closed 3 weeks ago

igor-sirotin commented 1 month ago

  1. Version

    I've used a combination of go:generate and go:embed to get the version into Go code.

    Currently version is only properly set when you build with Makefile commands. This solution makes it Makefile-agnostic. For example, I'm running status-backend with my IDE, which does go run ... (and attaches debugger).

  2. IPFS_GATEWAY_URL

    I've removed this parameter from Makefile, as it's not used. It's only set in status-mobile, but to the same value as the default one (and a fixme to remove it): https://github.com/status-im/status-mobile/blob/9c3ff8c88ca321e22bbfcece34ea389c9b18c5cd/nix/status-go/default.nix#L20-L21

status-im-auto commented 1 month ago

Jenkins Builds

Click to see older builds (34) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_multiplication_x: | 98dd91a6 | [#1](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6014/1/) | 2024-10-30 16:44:21 | ~1 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6014/1//consoleText) | | :heavy_check_mark: | 98dd91a6 | [#1](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-6014/1/) | 2024-10-30 16:47:40 | ~5 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241030-164235-98dd91-pr6014.zip) | | :heavy_check_mark: | 98dd91a6 | [#1](https://ci.status.im/job/status-go/job/prs/job/macos/job/aarch64/job/main/job/PR-6014/1/) | 2024-10-30 16:48:04 | ~5 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241030-164236-98dd91-pr6014.zip) | | :heavy_check_mark: | 98dd91a6 | [#1](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-6014/1/) | 2024-10-30 16:48:09 | ~5 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241030-164235-98dd91-pr6014.zip) | | :heavy_check_mark: | 98dd91a6 | [#1](https://ci.status.im/job/status-go/job/prs/job/macos/job/x86_64/job/main/job/PR-6014/1/) | 2024-10-30 16:48:33 | ~5 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241030-164238-98dd91-pr6014.zip) | | :heavy_check_mark: | 98dd91a6 | [#1](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-6014/1/) | 2024-10-30 16:48:49 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-241030-164233-98dd91-pr6014.aar) | | :heavy_check_mark: | 98dd91a6 | [#1](https://ci.status.im/job/status-go/job/prs/job/windows/job/x86_64/job/main/job/PR-6014/1/) | 2024-10-30 16:48:58 | ~6 min | `windows` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-windows-241030-164243-98dd91-pr6014.zip) | | :heavy_multiplication_x: | 98dd91a6 | [#1](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6014/1/) | 2024-10-30 17:17:38 | ~34 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6014/1//consoleText) | | :heavy_multiplication_x: | 98dd91a6 | [#2](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6014/2/) | 2024-10-31 11:28:56 | ~33 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6014/2//consoleText) | | | | | | | | | | :heavy_multiplication_x: | 8c30d6e6 | [#3](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6014/3/) | 2024-10-31 12:15:35 | ~4 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6014/3//consoleText) | | :heavy_check_mark: | 8c30d6e6 | [#2](https://ci.status.im/job/status-go/job/prs/job/windows/job/x86_64/job/main/job/PR-6014/2/) | 2024-10-31 12:15:53 | ~5 min | `windows` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-windows-241031-121051-8c30d6-pr6014.zip) | | :heavy_check_mark: | 8c30d6e6 | [#2](https://ci.status.im/job/status-go/job/prs/job/macos/job/aarch64/job/main/job/PR-6014/2/) | 2024-10-31 12:15:59 | ~5 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241031-121047-8c30d6-pr6014.zip) | | :heavy_check_mark: | 8c30d6e6 | [#2](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-6014/2/) | 2024-10-31 12:16:06 | ~5 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241031-121042-8c30d6-pr6014.zip) | | :heavy_check_mark: | 8c30d6e6 | [#2](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6014/2/) | 2024-10-31 12:16:16 | ~5 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6014/2//consoleText) | | :heavy_check_mark: | 8c30d6e6 | [#2](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-6014/2/) | 2024-10-31 12:16:44 | ~6 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241031-121043-8c30d6-pr6014.zip) | | :heavy_check_mark: | 8c30d6e6 | [#2](https://ci.status.im/job/status-go/job/prs/job/macos/job/x86_64/job/main/job/PR-6014/2/) | 2024-10-31 12:16:52 | ~6 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241031-121047-8c30d6-pr6014.zip) | | :heavy_check_mark: | 8c30d6e6 | [#2](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-6014/2/) | 2024-10-31 12:17:24 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-241031-121042-8c30d6-pr6014.aar) | | | | | | | | | | :heavy_check_mark: | 78adf1d6 | [#3](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6014/3/) | 2024-10-31 12:22:55 | ~4 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6014/3//consoleText) | | :heavy_check_mark: | 78adf1d6 | [#3](https://ci.status.im/job/status-go/job/prs/job/macos/job/aarch64/job/main/job/PR-6014/3/) | 2024-10-31 12:23:56 | ~5 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241031-121852-78adf1-pr6014.zip) | | :heavy_check_mark: | 78adf1d6 | [#3](https://ci.status.im/job/status-go/job/prs/job/windows/job/x86_64/job/main/job/PR-6014/3/) | 2024-10-31 12:23:56 | ~5 min | `windows` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-windows-241031-121856-78adf1-pr6014.zip) | | :heavy_check_mark: | 78adf1d6 | [#3](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-6014/3/) | 2024-10-31 12:24:05 | ~5 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241031-121849-78adf1-pr6014.zip) | | :heavy_check_mark: | 78adf1d6 | [#3](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-6014/3/) | 2024-10-31 12:24:45 | ~5 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241031-121850-78adf1-pr6014.zip) | | :heavy_check_mark: | 78adf1d6 | [#3](https://ci.status.im/job/status-go/job/prs/job/macos/job/x86_64/job/main/job/PR-6014/3/) | 2024-10-31 12:24:46 | ~5 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241031-121852-78adf1-pr6014.zip) | | :heavy_check_mark: | 78adf1d6 | [#3](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-6014/3/) | 2024-10-31 12:25:08 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-241031-121847-78adf1-pr6014.aar) | | :heavy_multiplication_x: | 78adf1d6 | [#4](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6014/4/) | 2024-10-31 12:52:27 | ~33 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6014/4//consoleText) | | :heavy_multiplication_x: | 78adf1d6 | [#5](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6014/5/) | 2024-10-31 15:03:46 | ~32 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6014/5//consoleText) | | | | | | | | | | :heavy_check_mark: | e1568300 | [#4](https://ci.status.im/job/status-go/job/prs/job/windows/job/x86_64/job/main/job/PR-6014/4/) | 2024-10-31 23:37:54 | ~3 min | `windows` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-windows-241031-233401-e15683-pr6014.zip) | | :heavy_check_mark: | e1568300 | [#4](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6014/4/) | 2024-10-31 23:38:01 | ~4 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6014/4//consoleText) | | :heavy_check_mark: | e1568300 | [#4](https://ci.status.im/job/status-go/job/prs/job/macos/job/aarch64/job/main/job/PR-6014/4/) | 2024-10-31 23:38:58 | ~5 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241031-233356-e15683-pr6014.zip) | | :heavy_check_mark: | e1568300 | [#4](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-6014/4/) | 2024-10-31 23:39:05 | ~5 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241031-233355-e15683-pr6014.zip) | | :heavy_check_mark: | e1568300 | [#4](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-6014/4/) | 2024-10-31 23:39:18 | ~5 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241031-233354-e15683-pr6014.zip) | | :heavy_check_mark: | e1568300 | [#4](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-6014/4/) | 2024-10-31 23:39:55 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-241031-233353-e15683-pr6014.aar) | | :heavy_check_mark: | e1568300 | [#4](https://ci.status.im/job/status-go/job/prs/job/macos/job/x86_64/job/main/job/PR-6014/4/) | 2024-10-31 23:40:01 | ~6 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241031-233357-e15683-pr6014.zip) | | :heavy_multiplication_x: | e1568300 | [#6](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6014/6/) | 2024-11-01 00:08:22 | ~34 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6014/6//consoleText) |
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_multiplication_x: e798d6bd #7 2024-11-01 12:47:22 ~2 min tests :page_facing_up:log
:heavy_check_mark: e798d6bd #5 2024-11-01 12:48:15 ~3 min windows :package:zip
:heavy_check_mark: e798d6bd #5 2024-11-01 12:48:25 ~4 min tests-rpc :page_facing_up:log
:heavy_check_mark: e798d6bd #5 2024-11-01 12:48:46 ~4 min macos :package:zip
:heavy_check_mark: e798d6bd #5 2024-11-01 12:49:04 ~4 min ios :package:zip
:heavy_check_mark: e798d6bd #5 2024-11-01 12:49:20 ~4 min linux :package:zip
:heavy_check_mark: e798d6bd #5 2024-11-01 12:50:24 ~6 min android :package:aar
:heavy_check_mark: e798d6bd #5 2024-11-01 12:50:24 ~6 min macos :package:zip
:heavy_check_mark: 5f8f9fca #6 2024-11-01 12:55:29 ~3 min macos :package:zip
:heavy_check_mark: 5f8f9fca #6 2024-11-01 12:55:36 ~3 min windows :package:zip
:heavy_check_mark: 5f8f9fca #6 2024-11-01 12:55:41 ~3 min tests-rpc :page_facing_up:log
:heavy_check_mark: 5f8f9fca #6 2024-11-01 12:56:20 ~4 min ios :package:zip
:heavy_check_mark: 5f8f9fca #6 2024-11-01 12:56:47 ~5 min linux :package:zip
:heavy_check_mark: 5f8f9fca #6 2024-11-01 12:57:52 ~6 min macos :package:zip
:heavy_check_mark: 5f8f9fca #6 2024-11-01 12:58:06 ~6 min android :package:aar
:heavy_check_mark: 5f8f9fca #8 2024-11-01 13:25:16 ~33 min tests :page_facing_up:log
codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.58%. Comparing base (c08e922) to head (5f8f9fc). Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
cmd/status-backend/main.go 0.00% 5 Missing :warning:
rpc/client.go 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #6014 +/- ## =========================================== - Coverage 60.62% 60.58% -0.04% =========================================== Files 812 813 +1 Lines 109328 109341 +13 =========================================== - Hits 66275 66246 -29 - Misses 35295 35326 +31 - Partials 7758 7769 +11 ``` | [Flag](https://app.codecov.io/gh/status-im/status-go/pull/6014/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [functional](https://app.codecov.io/gh/status-im/status-go/pull/6014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `13.00% <70.83%> (-0.09%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/status-im/status-go/pull/6014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `59.94% <89.47%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/status-im/status-go/pull/6014?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [api/geth\_backend.go](https://app.codecov.io/gh/status-im/status-go/pull/6014?src=pr&el=tree&filepath=api%2Fgeth_backend.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-YXBpL2dldGhfYmFja2VuZC5nbw==) | `54.72% <100.00%> (+0.05%)` | :arrow_up: | | [params/config.go](https://app.codecov.io/gh/status-im/status-go/pull/6014?src=pr&el=tree&filepath=params%2Fconfig.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-cGFyYW1zL2NvbmZpZy5nbw==) | `70.62% <100.00%> (ø)` | | | [params/version.go](https://app.codecov.io/gh/status-im/status-go/pull/6014?src=pr&el=tree&filepath=params%2Fversion.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-cGFyYW1zL3ZlcnNpb24uZ28=) | `100.00% <100.00%> (ø)` | | | [services/ext/service.go](https://app.codecov.io/gh/status-im/status-go/pull/6014?src=pr&el=tree&filepath=services%2Fext%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-c2VydmljZXMvZXh0L3NlcnZpY2UuZ28=) | `20.39% <100.00%> (ø)` | | | [telemetry/client.go](https://app.codecov.io/gh/status-im/status-go/pull/6014?src=pr&el=tree&filepath=telemetry%2Fclient.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-dGVsZW1ldHJ5L2NsaWVudC5nbw==) | `73.11% <ø> (ø)` | | | [rpc/client.go](https://app.codecov.io/gh/status-im/status-go/pull/6014?src=pr&el=tree&filepath=rpc%2Fclient.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-cnBjL2NsaWVudC5nbw==) | `65.74% <50.00%> (ø)` | | | [cmd/status-backend/main.go](https://app.codecov.io/gh/status-im/status-go/pull/6014?src=pr&el=tree&filepath=cmd%2Fstatus-backend%2Fmain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-Y21kL3N0YXR1cy1iYWNrZW5kL21haW4uZ28=) | `0.00% <0.00%> (ø)` | | ... and [34 files with indirect coverage changes](https://app.codecov.io/gh/status-im/status-go/pull/6014/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im)