Closed dlipicar closed 3 weeks ago
:grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
---|---|---|---|---|---|---|
:heavy_check_mark: | af7fe9f3 | #1 | 2024-10-30 22:57:25 | ~4 min | linux |
:package:zip |
:heavy_check_mark: | af7fe9f3 | #1 | 2024-10-30 22:58:05 | ~5 min | android |
:package:aar |
:heavy_check_mark: | af7fe9f3 | #1 | 2024-10-30 22:59:02 | ~6 min | tests-rpc |
:page_facing_up:log |
:heavy_check_mark: | af7fe9f3 | #1 | 2024-10-30 22:59:06 | ~6 min | ios |
:package:zip |
:heavy_check_mark: | af7fe9f3 | #1 | 2024-10-30 23:26:44 | ~33 min | tests |
:page_facing_up:log |
:heavy_check_mark: | 432cc363 | #2 | 2024-10-31 11:56:10 | ~2 min | android |
:package:aar |
:heavy_check_mark: | 432cc363 | #2 | 2024-10-31 11:56:29 | ~2 min | linux |
:package:zip |
:heavy_check_mark: | 432cc363 | #2 | 2024-10-31 11:59:06 | ~5 min | ios |
:package:zip |
:heavy_check_mark: | 432cc363 | #2 | 2024-10-31 11:59:18 | ~5 min | tests-rpc |
:page_facing_up:log |
:heavy_check_mark: | 432cc363 | #2 | 2024-10-31 12:26:45 | ~32 min | tests |
:page_facing_up:log |
Attention: Patch coverage is 35.71429%
with 9 lines
in your changes missing coverage. Please review.
Please upload report for BASE (
release/3.4.x@635f19e
). Learn more about missing BASE report.
Hi @pavloburykh
This fix changes the behaviour of BuildTransactionV2
which is only used in (buildTxForPath
->BuildTransactionsFromRoute
-> BuildTransactionsFromRoute
)
I've checked that desktop does indeed use the wallet_buildTransactionsFromRoute
API call.
But mobile doesn't use this endpoint (only wallet_buildTransaction
or wallet_buildRawTransaction
)
So mobile is not affected by this PR (nor by https://github.com/status-im/status-go/pull/6018).
So mobile is not affected by this PR
@friofry thanks a lot for reviewing.
@dlipicar before merging this PR, could you merge first this one https://github.com/status-im/status-go/pull/6020 there are 2 changes:
Fixes https://github.com/status-im/status-desktop/issues/16664
BuildTransaction
stage, instead of only building the transactions for the client to sign and confirm~ This is wrong, the parameters used imply the Tx doesn't get sent to the chain, it's only generated.https://github.com/user-attachments/assets/e129b31a-4ce2-43d2-a190-9c29653bb730