search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
727 stars 247 forks source link

feat_: integrate on-demand DNS discovery and implement discoverAndConnectPeers #6017

Closed gabrielmer closed 3 weeks ago

gabrielmer commented 3 weeks ago

Same PR as https://github.com/status-im/status-go/pull/6000 but over the updated base branch (rebase is not working properly in this case)

Integrating libwaku's on-demand DNS discovery functionality and implementing discoverAndConnectPeers

Notice that for discoverAndConnectPeers, we have to do it sequentially and not with goroutines, as libwaku doesn't work properly with goroutines for now (because of goroutines spinning up multiple threads and Nim being set up only in one).

Important changes:

Issue https://github.com/waku-org/nwaku/issues/3076

github-actions[bot] commented 3 weeks ago

We require commits to follow the Conventional Commits, but with _ for non-breaking changes. Please fix these commit messages:

implement discoverandConnectPeers
test test
initial dns discovery integration
status-im-auto commented 3 weeks ago

Jenkins Builds

Click to see older builds (7) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_multiplication_x: | 1d66fffd | [#1](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6017/1/) | 2024-10-31 10:01:41 | ~1 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6017/1//consoleText) | | :heavy_multiplication_x: | 1d66fffd | [#1](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6017/1/) | 2024-10-31 10:03:56 | ~4 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6017/1//consoleText) | | :heavy_check_mark: | 1d66fffd | [#1](https://ci.status.im/job/status-go/job/prs/job/macos/job/aarch64/job/main/job/PR-6017/1/) | 2024-10-31 10:04:41 | ~4 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241031-095950-1d66ff-pr6017.zip) | | :heavy_check_mark: | 1d66fffd | [#1](https://ci.status.im/job/status-go/job/prs/job/macos/job/x86_64/job/main/job/PR-6017/1/) | 2024-10-31 10:05:21 | ~5 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241031-095950-1d66ff-pr6017.zip) | | :heavy_check_mark: | 1d66fffd | [#1](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-6017/1/) | 2024-10-31 10:05:34 | ~5 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241031-095947-1d66ff-pr6017.zip) | | :heavy_check_mark: | 1d66fffd | [#1](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-6017/1/) | 2024-10-31 10:05:35 | ~5 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241031-095945-1d66ff-pr6017.zip) | | :heavy_multiplication_x: | 1d66fffd | [#1](https://ci.status.im/job/status-go/job/prs/job/windows/job/x86_64/job/main/job/PR-6017/1/) | 2024-10-31 10:10:40 | ~10 min | `windows` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-windows-241031-095952-1d66ff-pr6017.zip) |
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_multiplication_x: 4c81ce93 #2 2024-10-31 10:03:37 ~1 min tests :page_facing_up:log
:heavy_multiplication_x: 4c81ce93 #2 2024-10-31 10:09:23 ~4 min tests-rpc :page_facing_up:log
:heavy_check_mark: 4c81ce93 #2 2024-10-31 10:09:28 ~4 min macos :package:zip
:heavy_check_mark: 4c81ce93 #2 2024-10-31 10:10:48 ~5 min macos :package:zip
:heavy_check_mark: 4c81ce93 #2 2024-10-31 10:11:23 ~5 min ios :package:zip
:heavy_check_mark: 4c81ce93 #2 2024-10-31 10:11:28 ~5 min linux :package:zip
:heavy_check_mark: 4c81ce93 #2 2024-10-31 10:12:42 ~6 min android :package:aar
:heavy_multiplication_x: 4c81ce93 #2 2024-10-31 10:21:11 ~10 min windows :package:zip
:heavy_multiplication_x: f4eae163 #3 2024-10-31 14:41:49 ~2 min tests :page_facing_up:log
:heavy_multiplication_x: f4eae163 #3 2024-10-31 14:43:37 ~4 min tests-rpc :page_facing_up:log
:heavy_check_mark: f4eae163 #3 2024-10-31 14:44:33 ~4 min macos :package:zip
:heavy_check_mark: f4eae163 #3 2024-10-31 14:45:06 ~5 min linux :package:zip
:heavy_check_mark: f4eae163 #3 2024-10-31 14:45:16 ~5 min macos :package:zip
:heavy_check_mark: f4eae163 #3 2024-10-31 14:45:37 ~6 min android :package:aar
:heavy_check_mark: f4eae163 #3 2024-10-31 14:46:40 ~7 min ios :package:zip
:heavy_multiplication_x: f4eae163 #3 2024-10-31 14:50:10 ~10 min windows :package:zip
status-im-auto commented 3 weeks ago

:heavy_check_mark: status-go/prs/android/PR-6017#1 :small_blue_diamond: ~6 min 23 sec :small_blue_diamond: 1d66fffd :small_blue_diamond: :package: android package

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (feature/nwaku-in-status@6ac236d). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/nwaku-in-status #6017 +/- ## ========================================================== Coverage ? 0.00% ========================================================== Files ? 797 Lines ? 107347 Branches ? 0 ========================================================== Hits ? 0 Misses ? 107347 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/status-im/status-go/pull/6017/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [functional](https://app.codecov.io/gh/status-im/status-go/pull/6017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `0.00% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#carryforward-flags-in-the-pull-request-comment) to find out more.