search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
728 stars 247 forks source link

fix(wallet)_: use correct amount for erc1155 path processors #6018

Closed saledjenic closed 4 weeks ago

saledjenic commented 4 weeks ago

A proper amount is used for ERC1155 tokens.

Fixes https://github.com/status-im/status-desktop/issues/16664

This is the tx I've done sending erc1155:

status-im-auto commented 4 weeks ago

Jenkins Builds

:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 587f1f7f #1 2024-10-31 10:11:42 ~4 min macos :package:zip
:heavy_check_mark: 587f1f7f #1 2024-10-31 10:12:14 ~4 min tests-rpc :page_facing_up:log
:heavy_check_mark: 587f1f7f #1 2024-10-31 10:13:06 ~5 min linux :package:zip
:heavy_check_mark: 587f1f7f #1 2024-10-31 10:13:14 ~5 min windows :package:zip
:heavy_check_mark: 587f1f7f #1 2024-10-31 10:13:52 ~6 min android :package:aar
:heavy_check_mark: 587f1f7f #1 2024-10-31 10:14:30 ~7 min ios :package:zip
:heavy_check_mark: 587f1f7f #1 2024-10-31 10:15:28 ~7 min macos :package:zip
:heavy_check_mark: 587f1f7f #1 2024-10-31 10:41:28 ~33 min tests :page_facing_up:log
codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.80%. Comparing base (5d4838a) to head (587f1f7). Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...vices/wallet/transfer/transaction_manager_route.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #6018 +/- ## ============================================ + Coverage 13.16% 60.80% +47.64% ============================================ Files 795 810 +15 Lines 107391 108960 +1569 ============================================ + Hits 14133 66256 +52123 + Misses 91464 34948 -56516 - Partials 1794 7756 +5962 ``` | [Flag](https://app.codecov.io/gh/status-im/status-go/pull/6018/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [functional](https://app.codecov.io/gh/status-im/status-go/pull/6018/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `13.12% <0.00%> (-0.04%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/status-im/status-go/pull/6018/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `60.16% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/status-im/status-go/pull/6018?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [...vices/wallet/transfer/transaction\_manager\_route.go](https://app.codecov.io/gh/status-im/status-go/pull/6018?src=pr&el=tree&filepath=services%2Fwallet%2Ftransfer%2Ftransaction_manager_route.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-c2VydmljZXMvd2FsbGV0L3RyYW5zZmVyL3RyYW5zYWN0aW9uX21hbmFnZXJfcm91dGUuZ28=) | `43.00% <0.00%> (+0.78%)` | :arrow_up: | ... and [644 files with indirect coverage changes](https://app.codecov.io/gh/status-im/status-go/pull/6018/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im)
saledjenic commented 4 weeks ago

In this PR https://github.com/status-im/status-go/pull/6019 which is on top on this one I've added a small improvement, so it would be good to have them all in the release branch.

saledjenic commented 4 weeks ago

Closing this in favour of this one https://github.com/status-im/status-go/pull/6021