search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
727 stars 249 forks source link

chore(wallet)_: router tx improvements #6020

Closed saledjenic closed 3 weeks ago

saledjenic commented 3 weeks ago

Corresponding master PR https://github.com/status-im/status-go/pull/6019

status-im-auto commented 3 weeks ago

Jenkins Builds

:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 8467edf4 #1 2024-10-31 11:22:14 ~4 min linux :package:zip
:heavy_check_mark: 8467edf4 #1 2024-10-31 11:23:37 ~6 min tests-rpc :page_facing_up:log
:heavy_check_mark: 8467edf4 #1 2024-10-31 11:23:50 ~6 min android :package:aar
:heavy_check_mark: 8467edf4 #1 2024-10-31 11:23:58 ~6 min ios :package:zip
:heavy_check_mark: 8467edf4 #1 2024-10-31 11:51:37 ~34 min tests :page_facing_up:log
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.62%. Comparing base (af7fe9f) to head (8467edf). Report is 1 commits behind head on fix/use-proper-erc1155-transfer-value.

Files with missing lines Patch % Lines
...let/router/pathprocessor/processor_bridge_celar.go 0.00% 2 Missing :warning:
...allet/router/pathprocessor/processor_bridge_hop.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## fix/use-proper-erc1155-transfer-value #6020 +/- ## ========================================================================= - Coverage 47.65% 47.62% -0.03% ========================================================================= Files 843 843 Lines 138187 138184 -3 ========================================================================= - Hits 65848 65811 -37 - Misses 64550 64578 +28 - Partials 7789 7795 +6 ``` | [Flag](https://app.codecov.io/gh/status-im/status-go/pull/6020/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [functional](https://app.codecov.io/gh/status-im/status-go/pull/6020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `10.60% <55.55%> (-0.01%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/status-im/status-go/pull/6020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `46.94% <55.55%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/status-im/status-go/pull/6020?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [node/status\_node\_services.go](https://app.codecov.io/gh/status-im/status-go/pull/6020?src=pr&el=tree&filepath=node%2Fstatus_node_services.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-bm9kZS9zdGF0dXNfbm9kZV9zZXJ2aWNlcy5nbw==) | `71.19% <ø> (-0.07%)` | :arrow_down: | | [services/wallet/api.go](https://app.codecov.io/gh/status-im/status-go/pull/6020?src=pr&el=tree&filepath=services%2Fwallet%2Fapi.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-c2VydmljZXMvd2FsbGV0L2FwaS5nbw==) | `37.19% <100.00%> (-0.11%)` | :arrow_down: | | [...let/router/pathprocessor/processor\_stickers\_buy.go](https://app.codecov.io/gh/status-im/status-go/pull/6020?src=pr&el=tree&filepath=services%2Fwallet%2Frouter%2Fpathprocessor%2Fprocessor_stickers_buy.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-c2VydmljZXMvd2FsbGV0L3JvdXRlci9wYXRocHJvY2Vzc29yL3Byb2Nlc3Nvcl9zdGlja2Vyc19idXkuZ28=) | `11.42% <100.00%> (-1.25%)` | :arrow_down: | | [services/wallet/router/router.go](https://app.codecov.io/gh/status-im/status-go/pull/6020?src=pr&el=tree&filepath=services%2Fwallet%2Frouter%2Frouter.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-c2VydmljZXMvd2FsbGV0L3JvdXRlci9yb3V0ZXIuZ28=) | `80.26% <100.00%> (-0.04%)` | :arrow_down: | | [services/wallet/service.go](https://app.codecov.io/gh/status-im/status-go/pull/6020?src=pr&el=tree&filepath=services%2Fwallet%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-c2VydmljZXMvd2FsbGV0L3NlcnZpY2UuZ28=) | `96.55% <ø> (-0.06%)` | :arrow_down: | | [...let/router/pathprocessor/processor\_bridge\_celar.go](https://app.codecov.io/gh/status-im/status-go/pull/6020?src=pr&el=tree&filepath=services%2Fwallet%2Frouter%2Fpathprocessor%2Fprocessor_bridge_celar.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-c2VydmljZXMvd2FsbGV0L3JvdXRlci9wYXRocHJvY2Vzc29yL3Byb2Nlc3Nvcl9icmlkZ2VfY2VsYXIuZ28=) | `0.00% <0.00%> (ø)` | | | [...allet/router/pathprocessor/processor\_bridge\_hop.go](https://app.codecov.io/gh/status-im/status-go/pull/6020?src=pr&el=tree&filepath=services%2Fwallet%2Frouter%2Fpathprocessor%2Fprocessor_bridge_hop.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-c2VydmljZXMvd2FsbGV0L3JvdXRlci9wYXRocHJvY2Vzc29yL3Byb2Nlc3Nvcl9icmlkZ2VfaG9wLmdv) | `11.71% <0.00%> (-0.06%)` | :arrow_down: | ... and [26 files with indirect coverage changes](https://app.codecov.io/gh/status-im/status-go/pull/6020/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im)