search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
727 stars 249 forks source link

fix_: move version to separate package #6053

Closed igor-sirotin closed 2 weeks ago

igor-sirotin commented 2 weeks ago

Moved params/version.go to a separate internal/version package. This is needed to prevent import loops, e.g.:

graph LR
    common --wants sentry--> sentry --needs version--> common

will now be:

graph LR
    common --wants sentry--> sentry --needs version--> version
    common --also wants version-->version
status-im-auto commented 2 weeks ago

Jenkins Builds

:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: d5431fc4 #1 2024-11-06 12:24:45 ~4 min linux :package:zip
:heavy_check_mark: d5431fc4 #1 2024-11-06 12:24:54 ~4 min ios :package:zip
:heavy_check_mark: d5431fc4 #1 2024-11-06 12:25:12 ~5 min tests-rpc :page_facing_up:log
:heavy_check_mark: d5431fc4 #1 2024-11-06 12:25:32 ~5 min macos :package:zip
:heavy_check_mark: d5431fc4 #1 2024-11-06 12:25:48 ~5 min windows :package:zip
:heavy_check_mark: d5431fc4 #1 2024-11-06 12:26:49 ~6 min android :package:aar
:heavy_check_mark: d5431fc4 #1 2024-11-06 12:28:03 ~7 min macos :package:zip
:heavy_check_mark: d5431fc4 #1 2024-11-06 12:55:28 ~35 min tests :page_facing_up:log
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.85%. Comparing base (b329b15) to head (d5431fc). Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
cmd/status-backend/main.go 0.00% 2 Missing :warning:
rpc/client.go 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #6053 +/- ## =========================================== - Coverage 60.88% 60.85% -0.04% =========================================== Files 811 811 Lines 108894 108894 =========================================== - Hits 66303 66264 -39 - Misses 34841 34883 +42 + Partials 7750 7747 -3 ``` | [Flag](https://app.codecov.io/gh/status-im/status-go/pull/6053/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [functional](https://app.codecov.io/gh/status-im/status-go/pull/6053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `13.10% <69.23%> (+0.02%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/status-im/status-go/pull/6053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `60.21% <81.81%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/status-im/status-go/pull/6053?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [api/geth\_backend.go](https://app.codecov.io/gh/status-im/status-go/pull/6053?src=pr&el=tree&filepath=api%2Fgeth_backend.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-YXBpL2dldGhfYmFja2VuZC5nbw==) | `54.72% <100.00%> (ø)` | | | [internal/version/version.go](https://app.codecov.io/gh/status-im/status-go/pull/6053?src=pr&el=tree&filepath=internal%2Fversion%2Fversion.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-aW50ZXJuYWwvdmVyc2lvbi92ZXJzaW9uLmdv) | `100.00% <ø> (ø)` | | | [params/config.go](https://app.codecov.io/gh/status-im/status-go/pull/6053?src=pr&el=tree&filepath=params%2Fconfig.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-cGFyYW1zL2NvbmZpZy5nbw==) | `70.62% <100.00%> (ø)` | | | [services/ext/service.go](https://app.codecov.io/gh/status-im/status-go/pull/6053?src=pr&el=tree&filepath=services%2Fext%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-c2VydmljZXMvZXh0L3NlcnZpY2UuZ28=) | `20.39% <100.00%> (ø)` | | | [cmd/status-backend/main.go](https://app.codecov.io/gh/status-im/status-go/pull/6053?src=pr&el=tree&filepath=cmd%2Fstatus-backend%2Fmain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-Y21kL3N0YXR1cy1iYWNrZW5kL21haW4uZ28=) | `0.00% <0.00%> (ø)` | | | [rpc/client.go](https://app.codecov.io/gh/status-im/status-go/pull/6053?src=pr&el=tree&filepath=rpc%2Fclient.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-cnBjL2NsaWVudC5nbw==) | `65.74% <50.00%> (ø)` | | ... and [39 files with indirect coverage changes](https://app.codecov.io/gh/status-im/status-go/pull/6053/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im)