Open fbarbu15 opened 2 weeks ago
:grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
---|---|---|---|---|---|---|
:heavy_check_mark: | 8a194511 | #13 | 2024-11-11 14:53:11 | ~3 min | macos |
:package:zip |
:heavy_multiplication_x: | 8a194511 | #13 | 2024-11-11 14:53:15 | ~3 min | tests-rpc |
:page_facing_up:log |
:heavy_check_mark: | 8a194511 | #12 | 2024-11-11 14:53:15 | ~3 min | windows |
:package:zip |
:heavy_check_mark: | 8a194511 | #13 | 2024-11-11 14:55:35 | ~4 min | linux |
:package:zip |
:heavy_check_mark: | 8a194511 | #13 | 2024-11-11 14:56:25 | ~5 min | android |
:package:aar |
:heavy_check_mark: | 8a194511 | #12 | 2024-11-11 14:56:48 | ~5 min | macos |
:package:zip |
:heavy_check_mark: | 8a194511 | #12 | 2024-11-11 14:58:05 | ~7 min | ios |
:package:zip |
:heavy_check_mark: | 8a194511 | #11 | 2024-11-11 15:32:44 | ~32 min | tests |
:page_facing_up:log |
:heavy_check_mark: | 81136cbb | #13 | 2024-11-11 15:23:19 | ~3 min | windows |
:package:zip |
:heavy_check_mark: | 81136cbb | #14 | 2024-11-11 15:23:27 | ~3 min | macos |
:package:zip |
:heavy_check_mark: | 81136cbb | #13 | 2024-11-11 15:23:51 | ~4 min | ios |
:package:zip |
:heavy_check_mark: | 81136cbb | #14 | 2024-11-11 15:24:11 | ~4 min | tests-rpc |
:page_facing_up:log |
:heavy_check_mark: | 81136cbb | #14 | 2024-11-11 15:24:27 | ~4 min | linux |
:package:zip |
:heavy_check_mark: | 81136cbb | #13 | 2024-11-11 15:24:46 | ~5 min | macos |
:package:zip |
:heavy_check_mark: | 81136cbb | #14 | 2024-11-11 15:24:52 | ~5 min | android |
:package:aar |
:heavy_check_mark: | 81136cbb | #12 | 2024-11-11 16:04:52 | ~32 min | tests |
:page_facing_up:log |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 60.30%. Comparing base (
7ee45ba
) to head (81136cb
).
Hey @fbarbu15, great work, thank you ❤️
I didn't yet check the code, but do you think it's possible to split this into 2-3 PRs? E.g.:
- framework changes
- common functions
- test 1-1 chats
- test communities?
This would greatly simplify the burden of code review, and increase the speed of merging pieces. Otherwise the code review quality is very poor, it's very difficult to keep high concentration for so many changes.
I understand though that it's mostly just migration of existing tests. So even just a separate PR with framework adaptation (which is new code), and then tests on top will be super nice 🙌
Hi, thanks! Sure, I will split it but first I've discussed with Anton and he wants to adjust the PR a little so it runs status-backend and tests inside docker containers. After that, I will work in splitting the PR. I will move it to draft until then
Changes: