search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
727 stars 249 forks source link

fix(BC)_: Fix personal_sign RPC event processing #6090

Closed alexjba closed 13 hours ago

alexjba commented 1 week ago

Fixing the personal_sign RPC event parsing. Changed params from object array to string array.

https://docs.metamask.io/wallet/reference/json-rpc-methods/personal_sign/

Needed for https://github.com/status-im/status-desktop/issues/16015

status-im-auto commented 1 week ago

Jenkins Builds

Click to see older builds (16) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | 43f355a3 | [#1](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-6090/1/) | 2024-11-12 12:46:32 | ~4 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241112-124200-43f355-pr6090.zip) | | :heavy_check_mark: | 43f355a3 | [#1](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6090/1/) | 2024-11-12 12:46:36 | ~4 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6090/1//consoleText) | | :heavy_check_mark: | 43f355a3 | [#1](https://ci.status.im/job/status-go/job/prs/job/macos/job/aarch64/job/main/job/PR-6090/1/) | 2024-11-12 12:46:51 | ~4 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241112-124203-43f355-pr6090.zip) | | :heavy_check_mark: | 43f355a3 | [#1](https://ci.status.im/job/status-go/job/prs/job/windows/job/x86_64/job/main/job/PR-6090/1/) | 2024-11-12 12:46:55 | ~4 min | `windows` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-windows-241112-124206-43f355-pr6090.zip) | | :heavy_check_mark: | 43f355a3 | [#1](https://ci.status.im/job/status-go/job/prs/job/macos/job/x86_64/job/main/job/PR-6090/1/) | 2024-11-12 12:47:18 | ~5 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241112-124203-43f355-pr6090.zip) | | :heavy_check_mark: | 43f355a3 | [#1](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-6090/1/) | 2024-11-12 12:47:34 | ~5 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241112-124201-43f355-pr6090.zip) | | :heavy_check_mark: | 43f355a3 | [#1](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-6090/1/) | 2024-11-12 12:47:58 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-241112-124157-43f355-pr6090.aar) | | :heavy_check_mark: | 43f355a3 | [#1](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6090/1/) | 2024-11-12 13:17:10 | ~35 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6090/1//consoleText) | | :heavy_check_mark: | 43f355a3 | [#2](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6090/2/) | 2024-11-20 14:38:54 | ~2 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6090/2//consoleText) | | :heavy_check_mark: | 43f355a3 | [#2](https://ci.status.im/job/status-go/job/prs/job/macos/job/aarch64/job/main/job/PR-6090/2/) | 2024-11-20 14:40:59 | ~4 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241120-143629-43f355-pr6090.zip) | | :heavy_check_mark: | 43f355a3 | [#2](https://ci.status.im/job/status-go/job/prs/job/macos/job/x86_64/job/main/job/PR-6090/2/) | 2024-11-20 14:41:44 | ~5 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241120-143631-43f355-pr6090.zip) | | :heavy_check_mark: | 43f355a3 | [#2](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-6090/2/) | 2024-11-20 14:41:52 | ~5 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241120-143627-43f355-pr6090.zip) | | :heavy_check_mark: | 43f355a3 | [#2](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-6090/2/) | 2024-11-20 14:41:59 | ~5 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241120-143626-43f355-pr6090.zip) | | :heavy_check_mark: | 43f355a3 | [#2](https://ci.status.im/job/status-go/job/prs/job/windows/job/x86_64/job/main/job/PR-6090/2/) | 2024-11-20 14:41:59 | ~5 min | `windows` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-windows-241120-143634-43f355-pr6090.zip) | | :heavy_check_mark: | 43f355a3 | [#2](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-6090/2/) | 2024-11-20 14:42:34 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-241120-143626-43f355-pr6090.aar) | | :heavy_check_mark: | 43f355a3 | [#2](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6090/2/) | 2024-11-20 15:12:49 | ~36 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6090/2//consoleText) |
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: ad7fc344 #3 2024-11-20 16:20:23 ~3 min windows :package:zip
:heavy_check_mark: ad7fc344 #3 2024-11-20 16:20:44 ~4 min ios :package:zip
:heavy_check_mark: ad7fc344 #3 2024-11-20 16:21:27 ~4 min tests-rpc :page_facing_up:log
:heavy_check_mark: ad7fc344 #3 2024-11-20 16:21:40 ~5 min linux :package:zip
:heavy_check_mark: ad7fc344 #3 2024-11-20 16:21:57 ~5 min android :package:aar
:heavy_check_mark: ad7fc344 #3 2024-11-20 16:22:22 ~5 min macos :package:zip
:heavy_check_mark: ad7fc344 #3 2024-11-20 16:50:48 ~34 min tests :page_facing_up:log
:heavy_check_mark: 1df6c90e #4 2024-11-22 07:51:38 ~4 min windows :package:zip
:heavy_check_mark: 1df6c90e #4 2024-11-22 07:52:01 ~4 min macos :package:zip
:heavy_check_mark: 1df6c90e #4 2024-11-22 07:52:16 ~4 min ios :package:zip
:heavy_multiplication_x: 1df6c90e #4 2024-11-22 07:52:29 ~4 min tests-rpc :page_facing_up:log
:heavy_check_mark: 1df6c90e #4 2024-11-22 07:52:51 ~5 min macos :package:zip
:heavy_check_mark: 1df6c90e #4 2024-11-22 07:53:10 ~5 min linux :package:zip
:heavy_check_mark: 1df6c90e #4 2024-11-22 07:54:23 ~6 min android :package:aar
:heavy_check_mark: 1df6c90e #5 2024-11-22 08:07:56 ~7 min tests-rpc :page_facing_up:log
:heavy_check_mark: 1df6c90e #4 2024-11-22 08:20:51 ~33 min tests :page_facing_up:log
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.92%. Comparing base (3912e76) to head (1df6c90). Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
services/connector/commands/personal_sign.go 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #6090 +/- ## =========================================== - Coverage 60.93% 60.92% -0.01% =========================================== Files 820 820 Lines 109534 109533 -1 =========================================== - Hits 66743 66737 -6 + Misses 34957 34955 -2 - Partials 7834 7841 +7 ``` | [Flag](https://app.codecov.io/gh/status-im/status-go/pull/6090/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [functional](https://app.codecov.io/gh/status-im/status-go/pull/6090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `13.64% <0.00%> (+0.11%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/status-im/status-go/pull/6090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `60.11% <66.66%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/status-im/status-go/pull/6090?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [services/connector/commands/personal\_sign.go](https://app.codecov.io/gh/status-im/status-go/pull/6090?src=pr&el=tree&filepath=services%2Fconnector%2Fcommands%2Fpersonal_sign.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-c2VydmljZXMvY29ubmVjdG9yL2NvbW1hbmRzL3BlcnNvbmFsX3NpZ24uZ28=) | `75.00% <66.66%> (-0.76%)` | :arrow_down: | ... and [40 files with indirect coverage changes](https://app.codecov.io/gh/status-im/status-go/pull/6090/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im)