search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
727 stars 247 forks source link

feat_: add KeycardPairingKey #6101

Closed flexsurfer closed 5 days ago

flexsurfer commented 1 week ago

On mobile we don't have KeycardPairing json File, so we are unable to provide a path to it, so for recoveryAccount we'll pass a parameter KeycardPairingKey which will be used instead of KeycardPairing json File, on desktop it will continue work as it is

status-im-auto commented 1 week ago

Jenkins Builds

Click to see older builds (25) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | 3f23d17e | [#1](https://ci.status.im/job/status-go/job/prs/job/macos/job/aarch64/job/main/job/PR-6101/1/) | 2024-11-14 15:21:11 | ~4 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241114-151642-3f23d1-pr6101.zip) | | :heavy_check_mark: | 3f23d17e | [#1](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-6101/1/) | 2024-11-14 15:21:21 | ~4 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241114-151640-3f23d1-pr6101.zip) | | :heavy_check_mark: | 3f23d17e | [#1](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-6101/1/) | 2024-11-14 15:21:36 | ~4 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241114-151640-3f23d1-pr6101.zip) | | :heavy_check_mark: | 3f23d17e | [#1](https://ci.status.im/job/status-go/job/prs/job/macos/job/x86_64/job/main/job/PR-6101/1/) | 2024-11-14 15:21:55 | ~5 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241114-151643-3f23d1-pr6101.zip) | | :heavy_check_mark: | 3f23d17e | [#1](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6101/1/) | 2024-11-14 15:22:12 | ~5 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6101/1//consoleText) | | :heavy_check_mark: | 3f23d17e | [#1](https://ci.status.im/job/status-go/job/prs/job/windows/job/x86_64/job/main/job/PR-6101/1/) | 2024-11-14 15:22:31 | ~5 min | `windows` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-windows-241114-151647-3f23d1-pr6101.zip) | | :heavy_check_mark: | 3f23d17e | [#1](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-6101/1/) | 2024-11-14 15:23:23 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-241114-151638-3f23d1-pr6101.aar) | | :heavy_check_mark: | 3f23d17e | [#1](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6101/1/) | 2024-11-14 15:51:11 | ~34 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6101/1//consoleText) | | | | | | | | | | :heavy_check_mark: | babd14dd | [#2](https://ci.status.im/job/status-go/job/prs/job/macos/job/aarch64/job/main/job/PR-6101/2/) | 2024-11-19 12:46:20 | ~4 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241119-124216-babd14-pr6101.zip) | | :heavy_check_mark: | babd14dd | [#2](https://ci.status.im/job/status-go/job/prs/job/windows/job/x86_64/job/main/job/PR-6101/2/) | 2024-11-19 12:46:35 | ~4 min | `windows` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-windows-241119-124223-babd14-pr6101.zip) | | :heavy_check_mark: | babd14dd | [#2](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-6101/2/) | 2024-11-19 12:46:54 | ~4 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241119-124214-babd14-pr6101.zip) | | :heavy_check_mark: | babd14dd | [#2](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6101/2/) | 2024-11-19 12:47:24 | ~5 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6101/2//consoleText) | | :heavy_check_mark: | babd14dd | [#2](https://ci.status.im/job/status-go/job/prs/job/macos/job/x86_64/job/main/job/PR-6101/2/) | 2024-11-19 12:47:29 | ~5 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241119-124218-babd14-pr6101.zip) | | :heavy_check_mark: | babd14dd | [#2](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-6101/2/) | 2024-11-19 12:48:30 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-241119-124211-babd14-pr6101.aar) | | :heavy_check_mark: | babd14dd | [#2](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-6101/2/) | 2024-11-19 12:48:39 | ~6 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241119-124213-babd14-pr6101.zip) | | :heavy_check_mark: | babd14dd | [#2](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6101/2/) | 2024-11-19 13:16:25 | ~34 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6101/2//consoleText) | | | | | | | | | | :heavy_multiplication_x: | 4fc5e3ea | [#3](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6101/3/) | 2024-11-20 10:33:36 | ~3 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6101/3//consoleText) | | :heavy_check_mark: | 4fc5e3ea | [#3](https://ci.status.im/job/status-go/job/prs/job/windows/job/x86_64/job/main/job/PR-6101/3/) | 2024-11-20 10:34:32 | ~4 min | `windows` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-windows-241120-103021-4fc5e3-pr6101.zip) | | :heavy_check_mark: | 4fc5e3ea | [#3](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6101/3/) | 2024-11-20 10:34:38 | ~4 min | `tests-rpc` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6101/3//consoleText) | | :heavy_check_mark: | 4fc5e3ea | [#3](https://ci.status.im/job/status-go/job/prs/job/macos/job/aarch64/job/main/job/PR-6101/3/) | 2024-11-20 10:35:24 | ~5 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241120-103017-4fc5e3-pr6101.zip) | | :heavy_check_mark: | 4fc5e3ea | [#3](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-6101/3/) | 2024-11-20 10:35:35 | ~5 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-241120-103012-4fc5e3-pr6101.zip) | | :heavy_check_mark: | 4fc5e3ea | [#3](https://ci.status.im/job/status-go/job/prs/job/macos/job/x86_64/job/main/job/PR-6101/3/) | 2024-11-20 10:35:43 | ~5 min | `macos` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-macos-241120-103017-4fc5e3-pr6101.zip) | | :heavy_check_mark: | 4fc5e3ea | [#3](https://ci.status.im/job/status-go/job/prs/job/linux/job/x86_64/job/main/job/PR-6101/3/) | 2024-11-20 10:35:48 | ~5 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-linux-241120-103013-4fc5e3-pr6101.zip) | | :heavy_check_mark: | 4fc5e3ea | [#3](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-6101/3/) | 2024-11-20 10:36:28 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-241120-103011-4fc5e3-pr6101.aar) | | :heavy_multiplication_x: | 4fc5e3ea | [#4](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6101/4/) | 2024-11-20 10:37:01 | ~2 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-6101/4//consoleText) |
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_multiplication_x: ef93a8f5 #5 2024-11-20 10:51:32 ~2 min tests :page_facing_up:log
:heavy_check_mark: ef93a8f5 #4 2024-11-20 10:53:38 ~4 min windows :package:zip
:heavy_check_mark: ef93a8f5 #4 2024-11-20 10:53:53 ~4 min tests-rpc :page_facing_up:log
:heavy_check_mark: ef93a8f5 #4 2024-11-20 10:54:05 ~4 min macos :package:zip
:heavy_check_mark: ef93a8f5 #4 2024-11-20 10:54:39 ~5 min macos :package:zip
:heavy_check_mark: ef93a8f5 #4 2024-11-20 10:54:58 ~5 min linux :package:zip
:heavy_check_mark: ef93a8f5 #4 2024-11-20 10:55:18 ~5 min ios :package:zip
:heavy_check_mark: ef93a8f5 #4 2024-11-20 10:55:48 ~6 min android :package:aar
:heavy_check_mark: 56d4bdc7 #5 2024-11-20 11:00:17 ~4 min windows :package:zip
:heavy_check_mark: 56d4bdc7 #5 2024-11-20 11:00:36 ~4 min tests-rpc :page_facing_up:log
:heavy_check_mark: 56d4bdc7 #5 2024-11-20 11:00:44 ~4 min macos :package:zip
:heavy_check_mark: 56d4bdc7 #5 2024-11-20 11:01:12 ~5 min ios :package:zip
:heavy_check_mark: 56d4bdc7 #5 2024-11-20 11:01:21 ~5 min macos :package:zip
:heavy_check_mark: 56d4bdc7 #5 2024-11-20 11:01:43 ~5 min linux :package:zip
:heavy_check_mark: 56d4bdc7 #5 2024-11-20 11:02:11 ~6 min android :package:aar
:heavy_check_mark: 56d4bdc7 #6 2024-11-20 11:28:46 ~32 min tests :page_facing_up:log
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.92%. Comparing base (735a422) to head (56d4bdc). Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
api/geth_backend.go 46.66% 4 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #6101 +/- ## =========================================== - Coverage 60.93% 60.92% -0.02% =========================================== Files 819 819 Lines 109439 109444 +5 =========================================== - Hits 66690 66674 -16 - Misses 34926 34939 +13 - Partials 7823 7831 +8 ``` | [Flag](https://app.codecov.io/gh/status-im/status-go/pull/6101/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [functional](https://app.codecov.io/gh/status-im/status-go/pull/6101/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `13.53% <0.00%> (+<0.01%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/status-im/status-go/pull/6101/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | `60.14% <46.66%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/status-im/status-go/pull/6101?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [protocol/requests/create\_account.go](https://app.codecov.io/gh/status-im/status-go/pull/6101?src=pr&el=tree&filepath=protocol%2Frequests%2Fcreate_account.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-cHJvdG9jb2wvcmVxdWVzdHMvY3JlYXRlX2FjY291bnQuZ28=) | `33.33% <ø> (ø)` | | | [api/geth\_backend.go](https://app.codecov.io/gh/status-im/status-go/pull/6101?src=pr&el=tree&filepath=api%2Fgeth_backend.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-YXBpL2dldGhfYmFja2VuZC5nbw==) | `54.59% <46.66%> (-0.11%)` | :arrow_down: | ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/status-im/status-go/pull/6101/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im)
flexsurfer commented 6 days ago

thank @igor-sirotin, i've added the description, for 2) on mobile it's not needed because we don't have sync implemented, for desktop it will work fine.

flexsurfer commented 6 days ago

thank you @saledjenic i will create a task for mobile so we could research and improve that