search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
728 stars 246 forks source link

Disable NAT and inbound connections on mobiles #978

Closed dshulyak closed 6 years ago

dshulyak commented 6 years ago

Problem

We are not relying on hole punching using upnp which is provided by geth p2p server. So i would disable that goroutine from running, it might be confusing and can lead to questions/bugs in future.

Another problem is that someone could try to connect to mobile device if address with public address. We definitely should prevent this from happening.

Implementation

NAT hole punching is configured using an option to p2p.Config with a similar name. For inbound connections there was InboundRate or something similar.

Acceptance Criteria

NAT hole punching disabled on mobiles and inbound connections attempts are ignored or discarded.

status-github-bot[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

status-github-bot[bot] commented 6 years ago

This issue has been automatically closed. Please re-open if this issue is important to you.