search

status-im / status-js-desktop

A Status client reference implementation using status-js
MIT License
10 stars 3 forks source link

app needs an icon #10

Open samthomson opened 5 years ago

samthomson commented 5 years ago

I think the app could have an icon (standard status icon?). Seems straightforward to add an icon to electron apps for windows and unix builds, but an extra step (and sizes) are needed for mac. I'd be happy to have a look at this if you want to assign it to me. What do you think?

image

image

bgits commented 5 years ago

Sure, pull requests are welcome

bgits commented 5 years ago

The icon does not appear on mac os.

samthomson commented 5 years ago

My understanding is that setting the icon this way works only for linux/windows users. To set the icon for all platforms would require changing the build/packaging calls . Also for mac an icns file is required. Here's a PR with osx suitable icon which could be a starting point for changing the buidl/packaging process: https://github.com/status-im/status-js-desktop/pull/13 (adding icon flag).