Drop assisted key derivation support

status-im / status-keycard

Our Javacard Implementation for making secure transactions within Status and Ethereum

Apache License 2.0

215 stars 65 forks source link

Drop assisted key derivation support #14

Closed bitgamma closed 5 years ago

bitgamma commented 6 years ago

The assisted key derivation functionality is needed to support cards without KeyAgreement.ALG_EC_SVDP_DH_PLAIN_XY. This was implemented because no card actually implemented that and we will wanted to do BIP-32.

However, it is a workaround and it is not strictly necessary anymore. Removing it would allow removing quite a lot of code (making the applet smaller) and test cases.

guylouis commented 5 years ago

I agree this is not needed anymore. Latest cards on the market implement KeyAgreement.ALG_EC_SVDP_DH_PLAIN_XY, and a smaller applet will make a quicker upload of the applet either at the factory or through the client side.

bitgamma commented 5 years ago

Ok, before adding much new code I am going to remove the old cruft then

bitgamma commented 5 years ago

Closed by e78397c19894d7931fc2ac5c407be441a9fdc32f