status-im / status-keycard

Our Javacard Implementation for making secure transactions within Status and Ethereum
Apache License 2.0
213 stars 65 forks source link

Compilation error: package javax.smartcardio is not visible #49

Closed anwfr closed 5 years ago

anwfr commented 5 years ago

Hello, I followed the compilations instructions. When running ./gradlew convertJavacard (JDK 10.0.2) I get the following error:

/java-applet/buildSrc/src/main/java/im/status/keycard/build/InstallTask.java:12: error: package javax.smartcardio is not visible import javax.smartcardio.*; ^ (package javax.smartcardio is declared in module java.smartcardio, which is not in the module graph) /java-applet/buildSrc/src/main/java/im/status/keycard/build/InstallTask.java:49: error: cannot access CardChannel PCSCCardChannel sdkChannel = new PCSCCardChannel(apduCard.getBasicChannel()); ^ class file for javax.smartcardio.CardChannel not found 2 errors

FAILURE: Build failed with an exception.

  • What went wrong: Execution failed for task ':buildSrc:compileJava'.

    Compilation failed; see the compiler error output for details.

Any idea?

bitgamma commented 5 years ago

Keycard should be compiled using Java 8. SmartCard I/O is likely an optional module after Java 9 (because of project Jigsaw) and its usage must be declared.

anwfr commented 5 years ago

Thank you very much