Make the number of attempts before PIN lock down configurable

status-im / status-keycard

Our Javacard Implementation for making secure transactions within Status and Ethereum

Apache License 2.0

213 stars 65 forks source link

Closed guylouis closed 2 years ago

guylouis commented 4 years ago

Today this number is 3 and hardcoded. This could be setup as a parameter of the INIT command https://status.im/keycard_api/apdu/init.html

bitgamma commented 4 years ago

maybe we should limit the configurable value to some upper maximum and lower minimum though. I'd say to accept values between 2 and 10. Wdyt?

guylouis commented 4 years ago

makes sense !