status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.9k stars 987 forks source link

Add Binance Smart chain as main network #12760

Closed churik closed 2 years ago

churik commented 3 years ago

Bug Report

Problem

Requested by users. Currently can be added as custom network, but have ETH as main currency and transaction history can't be loaded

Expected behavior

1) Can see correct balance of BNB 2) Can see transaction history 3) Can easily switch to Binance smart chain as it will be in the list of Main networks

Actual behavior

Monosnap 2021-10-28 12-24-11 png 2021-10-28 12-26-57

IMAGE 2021-10-28 12:28:41

Reproduction

1) Open Status 2) Add custom network with params: URL: https://bsc-dataseed.binance.org/ ID: 56

Additional Information

churik commented 3 years ago

Basically, for any custom RPC chain we missing some optional params, which are using in MetaMask for instance (currency symbol, block explorer) Monosnap 2021-11-03 16-31-36 I believe it may be related to https://github.com/status-im/status-react/issues/12777 also, as we don't have blockcain explorer added on these chains (just an assumption)

Anyway, if custom RPC can work as it works in metamsk - that would be just awesome.

qoqobolo commented 3 years ago

Additional related issue that was reported from our user:

Cannot connect to Dapps in binance smart chain

Steps:

  1. Switch to Binance smart chain
  2. Open browser and navigate to some of the following DApps:
  1. Allow connection to the wallet

Expected behavior: can connect and use DApp normally Actual behavior: DApp and Status browser tabs freeze

OS: Android, iOS Status version: 1.17, Nightly 3/11

flexsurfer commented 3 years ago

@qoqobolo dapps are fixed here https://github.com/status-im/status-react/pull/12791

flexsurfer commented 3 years ago

@churik we don't use block explorers that's why history doesn't work, dunno might be @rasom could comment what we can do about that ,but most likely it depends on RPC if it supports methods we need for history or not