search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.9k stars 987 forks source link

ENS Warning showing on custom domains #13263

Closed daferna closed 2 years ago

daferna commented 2 years ago

Bug Report

image

Problem

The ENS Warning for misregistered accounts is incorrectly showing up on custom domains (non-.stateofus.eth) during the ENS Setup Flow. This is likely because pubkey() on the ENS Resolver returns all zeros for the x & y coordinates of the ECDSA pubkey for domains by default, and having a 0 y-component is the precondition for triggering this warning. This warning should only display for .stateofus.eth domains.

Expected behavior

The ENS Warning shows only for broken *.stateofus.us domains

Actual behavior

The ENS Warning shows for non *.stateofus.us domain that have a default 0/0 x/y ECDSA pubkey in their ENS Resolver contract

Reproduction

1) Try any ENS Name owned in one of the users accounts (either view-only, or imported via private-key/seedphrase)

Additional Information

It may be beneficial to restrict to the list of ETH addresses that were impacted, assuming said users do not transfer their domains to another address, but it's more likely any *.stateofus.eth domain with a 0 x or y component is broken.

daferna commented 2 years ago

Edited the bug report to confirm this is present in the latest stable release, 1.19.0 (20220328113003), and is blocking the use of possibly all custom ENS names.