status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.9k stars 988 forks source link

Add support for swipe gestures in other types of notifications #15117

Closed ilmotta closed 1 year ago

ilmotta commented 1 year ago

Feature Issue

The user should be able to swipe left/right in all types of notifications. Swipe left to toggle the unread state, swipe right to delete a notification. After PR https://github.com/status-im/status-mobile/pull/15106 is merged, the following notifications should be supported as well:

Transactions and System notifications are not yet supported anyway, so this issue shouldn't worry about them.

But what about notifications with CTA (call to action)?

What should happen if a user attempts to swipe left/right on a pending contact request? Should we allow swiping left/right? The answer is yes, but the positive/negative actions would be different and contextualized by the current state of the notification. Thus, for this issue, notifications with CTA should NOT allow swiping left/right. Also because the designs are not ready.

Resources

Figma Shell https://www.figma.com/file/eDfxTa9IoaCMUy5cLTp0ys/Shell-for-Mobile?node-id=5387%3A522478&t=vjvzHKAtKeSytBGd-0

ilmotta commented 1 year ago

This issue has been solved by PR https://github.com/status-im/status-mobile/pull/15284