status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.9k stars 988 forks source link

Allow message sender to toggle on/off link previews #15917

Open ilmotta opened 1 year ago

ilmotta commented 1 year ago

Problem

Depends on https://github.com/status-im/status-mobile/pull/15891

Not all users are willing to affect their privacy to share URLs with previews, so we should not always unfurl URLs.

Solution

Show a confirmation dialog the first time ever the user types a URL and no URL was ever unfurled. See Figma > Composer for Mobile. If the user has enabled link previews, then the dialog won't be shown again. In the future, the user will also be able to change this setting globally from setting's screens.

Implementation

The user's choice will need to persisted, hence changes in status-go will be required.

ilmotta commented 1 year ago

Just linking with issue https://github.com/status-im/status-desktop/issues/10866 on the Desktop app.

ajayesivan commented 1 year ago

I'm unassigning this issue as I am currently not working on it. Please feel free to pick it up. If no one takes it, I will reassign it to myself when I am able to actively work on it again.

igor-sirotin commented 1 year ago

status-go unfurling settings are tracked here: https://github.com/status-im/status-go/issues/4130