Wrong $ value for $FLX token on status wallet

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum

https://status.app

Mozilla Public License 2.0

3.9k stars 987 forks source link

Wrong $ value for $FLX token on status wallet #16129

Closed guylouis closed 1 year ago

guylouis commented 1 year ago

A user has reported on discord

he's using release 1.20.3
he owns 3000 tokens of FLX, contract 0x3ea8ea4237344c9931214796d9417af1a1180770.
status wallet shows a value of 47k$ when in reality it's worth around 100$
contract was double checked, it's the right one. Correct price is showing on CMC, CG and Deban

flexsurfer commented 1 year ago

cryptocompare.com provider is used for prices, and the token symbol is used (not contract) for fetching prices, so probably it's a different token https://www.cryptocompare.com/coins/flx/overview

flexsurfer commented 1 year ago

https://etherscan.io/token/0x6243d8cea23066d098a15582d81a598b4e8391f4

yes contract address is different

siddarthkay commented 1 year ago

he owns 3000 tokens of FLX,

To clarify a bit further, Currently 3000 FLX is worth approx. 49K and as mentioned by @flexsurfer the contract address is different.

siddarthkay commented 1 year ago

This means that status wallet indeed shows the correct value for $FLX token.

However the user that has reported this probably does not have the tokens they're claiming :)

guylouis commented 1 year ago

but https://etherscan.io/address/0x3ea8ea4237344c9931214796d9417af1a1180770 as the same ticker $FLX and this is the one contract the user has imported in status

doesn't this come down to:

when the user imports a new erc-20 token in status, are we checking (if even possible) that the ticker and smartcontract address actually match. This could avoid some user mistakes.
can we use the contract adress and not the ticker in the cryptocompare api?

flexsurfer commented 1 year ago

when the user imports a new erc-20 token in status, are we checking (if even possible) that the ticker and smartcontract address actually match. This could avoid some user mistakes.

yes, we're checking

can we use the contract adress and not the ticker in the cryptocompare api?

i guess no, only symbol supported by api

flexsurfer commented 1 year ago

However the user that has reported this probably does not have the tokens they're claiming :)

he has, but different token, there are 4 FLX tokens

cryptocompare supports only first one

cammellos commented 1 year ago

closing as this will be addressed in the new wallet