status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.88k stars 984 forks source link

Communities - Home - Display communities in all possible/valid states #16574

Open ilmotta opened 1 year ago

ilmotta commented 1 year ago

Feature/bug

In the Community Home screen, where communities are listed, we should display community items in all possible/valid states, such as when there are mentions, when they're muted, etc.

Recently, the Design System component quo/community-list-item (see Figma) has been rewritten to support all possible variations. Now it's a matter of using this component in the actual screens. This newly updated component is also being used in the Discover Communities screen.

As much as this issue can be seen as a feature, it's also about fixing what can be seen as UI bugs because we're not using the correct DS component, we're using quo2.components.community.community-list-view/communities-membership-list-item, but this is incorrect.

Acceptance criteria

Resources

andresceballosm commented 1 year ago

Hi @ilmotta, I was reviewing the quo/community-list-item component, and I have a pair of doubts, about props type and info, for example in type when should pass engage, discover, or share, Is the same situation for info, is there any documentation about it? or what can you tell me about it?

ilmotta commented 1 year ago

Hi @ilmotta, I was reviewing the quo/community-list-item component, and I have a pair of doubts, about props type and info, for example in type when should pass engage, discover, or share, Is the same situation for info, is there any documentation about it? or what can you tell me about it?

Hi @andresceballosm. As much as I would like to point out a good reference/doc to help you work on this issue, I have the same questions as you, and this issue requires the developer to dig a little bit.

Designers often add the majority of the app states in Figma screens (not the design system components, the DS is sort of agnostic of business rules), and Status' devs often reverse engineer the business rules from those screens, by analyzing the Clojure data structures in the Mobile app versus Figma. I would recommend this path first and foremost. All community related screens can be found in the Figma pages for Communities for Mobile (assuming you have read-only access).

Sometimes Figma is not enough and then I do a combination of:

Sorry if my answer is not super specific, but that's the nature of this GH issue.