search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.88k stars 984 forks source link

The layout of the recently received album is unstable when swiping or closing images (Android) #16597

Open pavloburykh opened 1 year ago

pavloburykh commented 1 year ago

Reproducing on Android 12, Samsung Galaxy A52

Preconditions: User A - Android, User B - any other device

Steps:

  1. User B sends photo album in chat with User A
  2. User A enters the chat and starts swiping/closing images of recently received album
  3. See how album behaves during swiping/closing images

Actual result: at some point album appears to be separated preventing from interacting with other app elements. See video below.

https://github.com/status-im/status-mobile/assets/97245802/4c0f7e35-097d-4391-b4ea-7fa02cfb62cc

Additional Information

mohsen-ghafouri commented 1 year ago

Hi @pavloburykh, I tested the album on Android 8.1, 12, and 14, but couldn't reproduce the issue. Could you please check to see if the problem is still reproducible or not? thanks

https://github.com/status-im/status-mobile/assets/71308738/308af1c6-64f3-44ea-be88-6ef4d7177a9b

pavloburykh commented 1 year ago

Hi @pavloburykh, I tested the album on Android 8.1, 12, and 14, but couldn't reproduce the issue. Could you please check to see if the problem is still reproducible or not? thanks

Screen.Recording.2023-08-29.at.18.37.20.mov

Hi @mohsen-ghafouri! Yes, it is still reproducible but this bug is kinda an edge case. See some more detailed reproduction steps below (point 3 is imporant)

Steps:

  1. User A located on the chats list screen
  2. User B sends album to User A
  3. User A enters chat with User B right after he sees notification about new message BUT before album is fully received on his side.
  4. User A starts opening and swiping those album images that were partially loaded
  5. Observe the result

Actual result: at some point album appears to be separated preventing from interacting with other app elements. See updated video below, maybe from this video it will be more clear how to reproduce the bug.

https://github.com/status-im/status-mobile/assets/97245802/8a2027fa-4510-495c-9987-9a02655a6a1a

mohsen-ghafouri commented 1 year ago

Thanks for clarification, i will try again

mohsen-ghafouri commented 1 year ago

After discussing with @OmarBasem, it seems that the issue is stemming from Reanimated. It seems this could be resolved by upgrading Reanimated to v3. So, I'll unassign this issue for now until we upgrade Reanimated (which is contingent on upgrading RN to v0.71+).

https://github.com/status-im/status-mobile/pull/17062

churik commented 2 months ago

I'll close it as stale, @pavloburykh please reopen it if still will be reproducible for you. also we upgraded to newer version, so could be resolved

pavloburykh commented 2 months ago

I'll close it as stale, @pavloburykh please reopen it if still will be reproducible for you. also we upgraded to newer version, so could be resolved

@churik reopening as it is still reproducible.

https://github.com/status-im/status-mobile/assets/97245802/a2ea9bdf-1665-4182-a5ae-180e4ca85b06