status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.9k stars 988 forks source link

Revisit downsampling function for charts #16831

Open briansztamfater opened 1 year ago

briansztamfater commented 1 year ago

Problem

We could have datasets of thousands of elements which would not be performant to render on mobile. To tackle that issue, we implemented downsampling function.

Some discussions in the original PR: https://github.com/status-im/status-mobile/pull/16789#discussion_r1280264332

Implementation

Once we have real data sets to start testing with, we would want to review this function to see if it fulfills our needs.

Acceptance Criteria

Decide to keep the same function or rather submit a PR with a new implementation. If the first option is decided, we can close this issue with a comment.

FFFra commented 6 months ago

Post MVP