status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.9k stars 985 forks source link

Add support for push notification when replying to a post in a community #16973

Open pavloburykh opened 1 year ago

pavloburykh commented 1 year ago

As a user I want to be notified when someone replies to my post in a community with a push notification So that I can reply promptly

Implementation

Currently replies are not supported in push notifications, only mentions. This change will require changes to both the status-go push notification client and status-go push notification server. The changes will have to be deployed to our fleet before they would be working.

https://github.com/status-im/status-go/tree/develop/protocol/pushnotificationclient

https://github.com/status-im/status-go/tree/develop/protocol/pushnotificationserver

Description (as bug)

Reproducing on IOS 16.5.1, iPhone X

Preconditions: User A - IOS, PNs are enabled. User B - any other device. User A and User B are members of the same community.

Steps:

  1. User B sends reply to User A in community channel
  2. See if User A received PN

Actual result: PN is not received

IOS_User_A_PN_receiver_logs.zip User_B_PN_sender_logs.zip

https://github.com/status-im/status-mobile/assets/97245802/66049ec8-f081-4162-8933-652e5921e4d4

Expected result: PN is received

Additional Information

cammellos commented 1 year ago

@pavloburykh this was never implemented for IOS, so it's not quite a bug, I will change it to a feature.