status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.85k stars 983 forks source link

Monospace text style #17009

Open ulisesmac opened 10 months ago

ulisesmac commented 10 months ago

Bug Report

Problem

The monospace text is not reproducible by using our monospace style for the text component.

An example is the context-tag component, in figma we have: image

which would be translated in our code to:

[text/text
  {:style  (style/text theme)
   :weight :monospace
   :size   :paragraph-2}
  address]

but it looks as follows: image

Expected behavior

Looks the same as designs.

Reproduction

Navigate to the context-tag component in Quo2.preview:

  1. Open Quo2.preview screen
  2. tags
  3. context-tag
  4. Set: type as address.
cammellos commented 10 months ago

@ulisesmac is that because 0x is not using a x but rather a × multiplication sign?

i.e 0xffff vs 0×ffff

Is that the issue or is it something else?

ulisesmac commented 10 months ago

@ulisesmac is that because 0x is not using a x but rather a × multiplication sign?

i.e 0xffff vs 0×ffff

Is that the issue or is it something else?

This is the link to figma: https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?type=design&node-id=1658-30911&mode=dev

It is an x(letter), not × (sign) image

Also, our text is not as bold as in designs, and I think we cannot change the weight since it is already being used to set the monospace style.

briansztamfater commented 8 months ago

We also need Semibold and Medium variants to our Monospace fonts, and add them in quo2.foundations.typography namespace (plus integrate new variants in our components)