search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.9k stars 988 forks source link

Check and fix button blur #17119

Closed OmarBasem closed 1 year ago

OmarBasem commented 1 year ago

There are some inconsistencies between the button blur in this flow and the button blur designs. The blurred buttons in the top nav component have a background of neutral-80-opa-5 and the reaction button has a blur of white-opa-5, meanwhile both buttons have the same exact properties.

It needs to be checked and fixed whether there is a mistake in the main button designs, or in the flow, or in our implementation.

Also, currently, the implementation would display a blurred button only when the background is of type photo. It should display blurred button when the background if of type blur also.

cc @J-Son89

J-Son89 commented 1 year ago

@OmarBasem can we close this issue now?

OmarBasem commented 1 year ago

@J-Son89 I think that part is not fixed yet?

Also, currently, the implementation would display a blurred button only when the background is of type photo. It should display blurred button when the background if of type blur also.

J-Son89 commented 1 year ago

I'm not sure we actually want that. Let's check with the designers 👍

J-Son89 commented 1 year ago

Discussed with @pedro-et, current button implementation is correct 👍