Profile photo is not updated correctly in case of backup + restoring with seed phrase or in case of sync

[VolodLytvynenko]

There are several scenarios of this issue:

1. Photo is not set when creating a user > Backup > Recover > Photo is set during onboarding

Steps:

1. Create a user without profile photo
2. Go to Settings > Sync settings > Backup settings > Press Perform backup
3. Save the seed phrase
4. Reinstall the app
5. Recover the user with the seed phrase
6. Set a profile photo during onboarding
7. Check your photo in profile

Actual result:

The photo is not fetched after onboarding

https://github.com/status-im/status-mobile/assets/52490791/0009f2de-b01b-4279-b29e-d4abbe14993b

Expected result:

The photo is fetched

Logs:

Status.log geth.log

---

2. Photo is set when creating a user > Backup > Recover > New photo is set during onboarding

Steps:

1. Create a user, set a profile photo
2. Perform backup
3. Save the seed phrase
4. Reinstall the app
5. Restore your user using the recovery phrase
6. On the Create profile step set a new photo
7. Check your photo in profile

Actual result:

The old photo is restored

Expected result:

The photo is updated, the new photo added during onboarding is displayed

---

3. Photo is set when creating a user > Backup > Recover > No photo is set during onboarding

Not sure about expected result in this case.

Steps:

1. Create a user, set a profile photo
2. Perform backup
3. Save the seed phrase
4. Reinstall the app
5. Restore your user using the recovery phrase
6. Do not add a photo on the Create profile step
7. Check your photo in profile

[cammellos]

This has to do with status-go, you need to check whether the picture has been backed up. Most likely it wasn't backed up. @VolodLytvynenko does it happens all the times even on accounts that you have been using for a while, or only on new accounts?

[VolodLytvynenko]

This has to do with status-go, you need to check whether the picture has been backed up. Most likely it wasn't backed up.

@cammellos Sorry for the delayed reply. Yes, you are correct. It happens if the image is not backed up.

@VolodLytvynenko does it happens all the times even on accounts that you have been using for a while, or only on new accounts?

This issue occurs for both non-backed-up image users with old accounts and new accounts. Thank you for helping to find the exact steps!

Steps:

1. Create an account (don't set image during onboarding)
2. Perform backup (or use existing user using seed phrase: catch salt eternal clever admit border mirror claw distance bring dwarf zebra)
3. Set image for avatar
4. Remove current account
5. Recover current account
6. Set image during onboarding
7. Check the image showing after onboarding

Actual result:

The image is not fetched after onboarding

[qoqobolo]

Digged into this issue a bit deeper and it turned out that there are several scenarios related to updating the photo after backup and account restoration. Updated the description.

Most likely it wasn't backed up

Judging by scenario 2, it looks like the photo was backed up, but not updated correctly.

[yqrashawn]

Unassign myself cause don't have time for this right now

[churik]

It is extremely visible for every user (recovered account), so I added it back. So basically when you recover a user that already has a photo and set a new photo, you can see this placeholder instead of a new one.

[churik]

As it is possible to fix it when you're setting a new picture in your profile, I do not consider it a blocker taking into account new priorities, descoping for now

[churik]

It got worse - no there are no even default placeholder or identity rings are shown. Checked on user, that has no photo set (synced app on desktop with mobile)

https://github.com/status-im/status-mobile/assets/4557972/1be95b41-708a-457f-97d8-467e842d7201