status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.91k stars 984 forks source link

Zoom controls don't work in chat camera #17358

Closed qoqobolo closed 1 year ago

qoqobolo commented 1 year ago

Bug Report

Problem

The 0,5x, 1x, 2x, 3x zoom buttons don't work in camera in the chat view. Pinch works fine.

https://github.com/status-im/status-mobile/assets/67952253/5d7904e8-18eb-456d-a847-ab6bfc4da81c

Reproduction

  1. Open chat
  2. Open camera
  3. Try to zoom in or out using 2x, 3xetc zoom controls

Additional Information

ibrkhalil commented 1 year ago

Unassigning as I'd need XCode 15 to work on this, And I still need to install Ventura on my Hackintosh to get XCode 15. Will do it later if no one picks it up.

ibrkhalil commented 1 year ago

Upgraded, Reassigning myself.

ibrkhalil commented 1 year ago

Had to unassign as I don't have capacity, Will pick it up if no one did when I finish what I have.

ibrkhalil commented 1 year ago

I researched the issue, And I found that controlling the zoom programmatically is still in pre-release of react-native-camera-kit, Check the changelog here

ibrkhalil commented 1 year ago

I'll give integrating the beta a shot.

ibrkhalil commented 1 year ago

Done 😄