search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.91k stars 984 forks source link

Block screenshots is enabled after sync on Android #18040

Open pavloburykh opened 11 months ago

pavloburykh commented 11 months ago

Steps:

  1. User A (Desktop) generates sync QR
  2. User B (Android) scans sync QR
  3. User B go Profile => Privacy and Security. Check if block screenshots toggle is disabled.

Actual result: block screenshots toggle is enabled.

Monosnap 2023-11-29 11-39-59

Expected result: block screenshots toggle is disabled by default on PR and nightly builds. Sync should not affect this toggle. Block screenshots toggle can be enabled by user manually. Also it is enabled by default in release builds - this behaviour should remain the same after fix.

Additional Information

ilmotta commented 1 month ago

@pavloburykh, am I correct to interpret that this issue only affects non-release builds? Usually we avoid writing custom code to force features to behave differently for different environments because it adds unnecessary complexity. Resolving this problem will require making the migration code adaptable per environment, which is something we don't want.

If this issue is not affecting QA significantly, do you think we can close it?