search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.9k stars 987 forks source link

Wallet: fiat decimal places #18227

Open OmarBasem opened 10 months ago

OmarBasem commented 10 months ago

This issue may need some work to be done first to be able to change the currency.

How many decimal places to display for each currency?

Fiat currencies should always be displayed using the ISO defined no. of decimal places, see https://bit.ly/34eSF71 Stablecoins that are pegged to a fiat currency should always use the same number of decimal places used by the fiat currency it is pegged to.

Original discussion: https://github.com/status-im/status-desktop/issues/8640

OmarBasem commented 10 months ago

@J-Son89 I think this issue may not be relevant for 1.27 as currency switching needs to be implemented first?

J-Son89 commented 10 months ago

I believe we can use the old currency switching for the time being. In profile -> legacy settings -> advanced options -> set currency cc @smohamedjavid

smohamedjavid commented 10 months ago

I guess this issue requires a currencies list with decimal places which the old list (legacy.status-im.utils.currency ns) doesn't have.

But, we have the old currency switching functionality that can be done with steps provided by @J-Son89.

We need to have the list in status-go and served to clients (Desktop and Mobile) along with the number of decimal places for each currency. The work is yet to be started.

We can work on this ticket after that is completed.

J-Son89 commented 9 months ago

From discussions we can use the endpoint- https://github.com/status-im/status-go/blob/5ec55fdb3002cc3494dd711db07e1a4cfa5f5562/services/wallet/api.go#L568-L576