status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.91k stars 984 forks source link

Quo - Profile/ collectible-list-item add support for SVG's #19251

Open J-Son89 opened 8 months ago

J-Son89 commented 8 months ago

using the component - https://github.com/status-im/status-mobile/issues/19086

Technical details

This component will be used to render many collectilbles at once, so we must pay attention to the rendering time, also we should keep in mind we'll render collectilbes from an external source, they'll come in as links.

Sometimes the SVGs received contain colors without the # at the beginning, so they throw an exception/warning on the console because react-native-svg isn't able to understand them, some alternative are:

So we should pick the best in terms of stability, memory consumption and performance.

Additionally, collectibles can be anything, so make sure to properly handle the "Unsupported file" variant.

Sometimes collectibles returned contain empty strings as links, in those cases we should render the "Can't fetch info" variant.

Align with @ulisesmac before starting this

OmarBasem commented 5 months ago

Any updates on this issue or is it still relevant?

ulisesmac commented 5 months ago

Any updates on this issue or is it still relevant?

@OmarBasem Still relevant. We need to add support for SVG collectibles in a performant way in the app

J-Son89 commented 5 months ago

@mmilad75 we can probably park this for now, I think there are more pressing issues to work on for the 2.30 release. wdyt?