search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.88k stars 984 forks source link

Preferred routes not fetched when sending assets to additional account #19779

Open VolodLytvynenko opened 4 months ago

VolodLytvynenko commented 4 months ago

Follow up for https://github.com/status-im/status-mobile/pull/19668

Steps:

  1. Create an additional account -> Open -> edit -> open network preferences of current account -> Select particular network as preferences
  2. Go to send flow using your first main account
  3. Select your additional account in the 'accounts' tab to send assets

Actual result:

All routes are fetched

https://github.com/status-im/status-mobile/assets/52490791/e326561c-1f2d-4227-95c8-c44ebc167b33

Expected result:

Only the preferred routes selected in step 1 for the additional account in network preferences should be fetched

OS:

IOS, Android

Devices:

VolodLytvynenko commented 4 months ago

NOTE for QA:

take a look, at the preferable test cases https://ethstatus.testrail.net/index.php?/cases/view/730716 which can be run as sanity after the fixing of this issue

churik commented 4 months ago

I believe this one and other routing issues should be fixed in scope a bit later, reference https://github.com/status-im/status-desktop/issues/14569

Removed from milestone for now

OmarBasem commented 1 month ago

@J-Son89 I think this one is now out of scope for 2.30-2.31?

churik commented 1 month ago

I'd say out of scope for 2.30