status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.88k stars 984 forks source link

Collectibles list contains unsupported images (when they have images on OpenSea) #19816

Open mariia-skrypnyk opened 4 months ago

mariia-skrypnyk commented 4 months ago

Bug Report

https://github.com/status-im/status-mobile/pull/19528#issuecomment-2059364553 was discussed here

Problem

Sometimes we can see Unsupported files in Collectibles list

Screenshot 2024-04-26 at 14 36 58

Expected behavior

I suppose we need to handle more image types (probably the most popular one's)

Actual behavior

Collectibles list contains unsupported images

Reproduction

  1. Login to app with a User who has a big number of collectibles
  2. Open Wallet -> Collectibles tab
  3. Starts to scroll your collectibles

Additional Information

FFFra commented 4 months ago

Maybe this is duplicated? #18527

J-Son89 commented 4 months ago

@mariia-skrypnyk - this is expected to have in the designs. Are you aware of any particular formats that are missing at the moment in which we should include?

mariia-skrypnyk commented 4 months ago

@mariia-skrypnyk - this is expected to have in the designs. Are you aware of any particular formats that are missing at the moment in which we should include?

Hi @J-Son89 !

No, I do not have any particular format to share now. But I can keep it in mind and update the information here in case I find it.

churik commented 2 months ago

An interesting thing is that I can see the image on Opensea, for example: https://opensea.io/assets/ethereum/0x3ca5b00ade54365fbd590d4bc397e044a13068e5/4346

https://github.com/status-im/status-mobile/assets/4557972/0073985a-62b4-486a-8887-ab2a18b25037

I'm not certain though about how we are retrieving images, so seems unexpected to me to have discrepancies with OpenSea on the matter.

churik commented 2 months ago

increasing priority of this, as even very popular collectibles (i.e. ENS) don't have a picture, and display a fallback icon IMAGE 2024-06-24 14:06:17

churik commented 2 months ago

cross-reference https://github.com/status-im/status-mobile/issues/19950