search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.88k stars 984 forks source link

Selecting / unselecting account addresses during editing does not affect channel permissions #19848

Open pavloburykh opened 4 months ago

pavloburykh commented 4 months ago

Originally reported here https://github.com/status-im/status-mobile/pull/19623#issuecomment-2064102939

Preconditions: here are my community permissions:

  1. Anyone who holds MBCOL is eligible to join as Member
  2. Anyone who holds CNONE is eligible to View and Post in chan-1
Status Desktop 2024-04-18 17-36-37

My mobile user holds MBCOL on Membership account and CNONE on chan 2 account (you can see it on video below the Steps)

Steps:

  1. Mobile user opens community
  2. Unselect chan 2 account which holds CNONE collectible required to access chan-1 channel
  3. Join the community
  4. After joining open Editing shared addresses
  5. Select chan 2 account which holds CNONE collectible required to access chan-1 channel
  6. Confirm changes
  7. See if mobile user is able to access chan-1

Expected result: user is able to access chan-1 as he shared chan 2 account which holds CNONE collectible required to access chan-1 channel

Actual result: unable to access chan-1 channel as it remains locked.

Desktop_control_node.log.zip mobile_user_edited_address.zip

https://github.com/status-im/status-mobile/assets/97245802/f89c5e07-ccc5-487b-9632-767ad67702b9

IMPORTANT:

This bug is related not only to Editing shared addresses feature. Basically the same will happen if you leave the community and re-join it with newly selected addresses. Actual result will be: channel permissions will work according to selected addresses durring you joined community for the first time.

churik commented 4 months ago

@pavloburykh

This bug is related not only to Editing shared addresses feature. Basically the same will happen if you leave the community and re-join it with newly selected addresses. Actual result will be: channel permissions will work according to selected addresses durring you joined community for the first time.

was not reproduced for me, after leaving - re-joining new address was shared. Checked on develop 01/05/24