Closed codemaster115 closed 1 week ago
:grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
---|---|---|---|---|---|---|
:x: | 7c90542cea47e2dafe59be51166deca9994adf85 | #12 | 2024-05-07 12:55:29 | ~5 min | tests |
:page_facing_up:log |
:heavy_check_mark: | 7c90542cea47e2dafe59be51166deca9994adf85 | #11 | 2024-05-07 12:58:55 | ~9 min | ios |
:iphone:ipa :calling: |
:heavy_check_mark: | 7c90542cea47e2dafe59be51166deca9994adf85 | #11 | 2024-05-07 13:02:50 | ~13 min | android-e2e |
:robot:apk :calling: |
:heavy_check_mark: | 7c90542cea47e2dafe59be51166deca9994adf85 | #11 | 2024-05-07 13:04:10 | ~14 min | android |
:robot:apk :calling: |
:heavy_check_mark: | 9dd48da4873c044a2a9c8fbba0022af1523c7d46 | #13 | 2024-05-07 13:26:40 | ~6 min | tests |
:page_facing_up:log |
:heavy_check_mark: | 9dd48da4873c044a2a9c8fbba0022af1523c7d46 | #12 | 2024-05-07 13:29:38 | ~9 min | ios |
:iphone:ipa :calling: |
:heavy_check_mark: | 9dd48da4873c044a2a9c8fbba0022af1523c7d46 | #12 | 2024-05-07 13:31:53 | ~12 min | android-e2e |
:robot:apk :calling: |
:heavy_check_mark: | 9dd48da4873c044a2a9c8fbba0022af1523c7d46 | #12 | 2024-05-07 13:32:04 | ~12 min | android |
:robot:apk :calling: |
Total executed tests: 52
Failed tests: 5
Expected to fail tests: 2
Passed tests: 45
IDs of failed tests: 727230,702782,702783,727229,703391
IDs of expected to fail tests: 703495,703503
1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 |
``` critical/chats/test_1_1_public_chats.py:117: in test_1_1_chat_emoji_send_reply_and_open_link self.chat_1.quote_message(emoji_unicode) ../views/chat_view.py:1040: in quote_message self.chat_view_element_starts_with_text(message).long_press_until_element_is_shown(self.reply_message_button) ../views/base_element.py:331: in long_press_until_element_is_shown action.long_press(element).release().perform() ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/common/touch_action.py:174: in perform self._driver.execute(Command.TOUCH_ACTION, params) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute self.error_handler.check_response(response) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace)) The element 'By.xpath: //*[@content-desc=':chat-floating-screen']//*[starts-with(@text,'ππ»ββοΈ')]' is not linked to the same object in DOM anymore; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception E Stacktrace: E io.appium.uiautomator2.common.exceptions.StaleElementReferenceException: The element 'By.xpath: //*[@content-desc=':chat-floating-screen']//*[starts-with(@text,'ππ»ββοΈ')]' is not linked to the same object in DOM anymore E at io.appium.uiautomator2.model.ElementsCache.restore(ElementsCache.java:122) E at io.appium.uiautomator2.model.ElementsCache.get(ElementsCache.java:153) E at io.appium.uiautomator2.handler.Location.safeHandle(Location.java:23) E at io.appium.uiautomator2.handler.request.SafeRequestHandler.handle(SafeRequestHandler.java:59) E at io.appium.uiautomator2.server.AppiumServlet.handleRequest(AppiumServlet.java:277) E at io.appium.uiautomator2.server.AppiumServlet.handleHttpRequest(AppiumServlet.java:271) E at io.appium.uiautomator2.http.ServerHandler.channelRead(ServerHandler.java:68) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435) E at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293) E at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267) E at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1294) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:911) E at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131) E at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611) E at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552) E at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466) E at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438) E at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140) E at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144) E at java.lang.Thread.run(Thread.java:1012) ``` Device sessions Device 1: Device 2: |
2. test_1_1_chat_send_image_save_and_share, id: 703391 |
``` critical/chats/test_1_1_public_chats.py:458: in test_1_1_chat_send_image_save_and_share self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Not expected image is shown to the receiver. ``` Device sessions Device 1: Device 2: |
1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 |
``` critical/chats/test_1_1_public_chats.py:614: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message status was not changed to Delivered, it's Sent after back up online! ``` Device sessions Device 1: Device 2: |
1. test_wallet_send_asset_from_drawer, id: 727230 |
``` critical/test_wallet.py:117: in test_wallet_send_asset_from_drawer sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx() critical/test_wallet.py:39: in _get_balances_before_tx self.wallet_1.wallet_tab.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception ``` |
2. test_wallet_send_eth, id: 727229 |
``` critical/test_wallet.py:109: in test_wallet_send_eth self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send) ../views/wallet_view.py:97: in send_asset self.confirm_transaction() ../views/wallet_view.py:84: in confirm_transaction self.slide_and_confirm_with_password() ../views/wallet_view.py:78: in slide_and_confirm_with_password self.slide_button_track.slide() ../views/base_view.py:257: in slide self.swipe_right_on_element(width_percentage=1.3, start_x=100) ../views/base_element.py:308: in swipe_right_on_element location, size = self.get_element_coordinates() ../views/base_element.py:294: in get_element_coordinates element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception ``` |
1. test_group_chat_mute_chat, id: 703495 |
``` critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Chat is still muted after timeout ``` [[Chat is not unmuted after expected time: https://github.com/status-im/status-mobile/issues/19627]] Device sessions Device 1: Device 2: Device 3: |
1. test_community_discovery, id: 703503 |
```
Test is not run, e2e blocker
```
[[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]] |
1. test_activity_center_mentions, id: 702957 |
Device sessions Device 1: Device 2: |
2. test_activity_center_admin_notification_accept_swipe, id: 702958 |
Device sessions Device 1: Device 2: |
1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
Device sessions Device 1: |
2. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
Device sessions Device 1: |
3. test_community_undo_delete_message, id: 702869 |
Device sessions Device 1: |
4. test_community_navigate_to_channel_when_relaunch, id: 702846 |
Device sessions Device 1: |
5. test_community_mute_community_and_channel, id: 703382 |
Device sessions Device 1: |
1. test_navigation_jump_to, id: 702936 |
Device sessions Device 1: Device 2: |
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 |
Device sessions Device 1: Device 2: |
1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 |
Device sessions Device 1: Device 2: |
2. test_1_1_chat_mute_chat, id: 703496 |
Device sessions Device 1: Device 2: |
1. test_group_chat_pin_messages, id: 702732 |
Device sessions Device 1: Device 2: Device 3: |
2. test_group_chat_send_image_save_and_share, id: 703297 |
Device sessions Device 1: Device 2: Device 3: |
3. test_group_chat_reactions, id: 703202 |
Device sessions Device 1: Device 2: Device 3: |
4. test_group_chat_join_send_text_messages_push, id: 702807 |
Device sessions Device 1: Device 2: Device 3: |
5. test_group_chat_offline_pn, id: 702808 |
Device sessions Device 1: Device 2: Device 3: |
1. test_community_several_images_send_reply, id: 703194 |
Device sessions Device 1: Device 2: |
2. test_community_one_image_send_reply, id: 702859 |
Device sessions Device 1: Device 2: |
3. test_community_emoji_send_copy_paste_reply, id: 702840 |
Device sessions Device 1: Device 2: |
4. test_community_mark_all_messages_as_read, id: 703086 |
Device sessions Device 1: Device 2: |
5. test_community_contact_block_unblock_offline, id: 702894 |
Device sessions Device 1: Device 2: |
6. test_community_edit_delete_message_when_offline, id: 704615 |
Device sessions Device 1: Device 2: |
7. test_community_message_delete, id: 702839 |
Device sessions Device 1: Device 2: |
8. test_community_message_send_check_timestamps_sender_username, id: 702838 |
Device sessions Device 1: Device 2: |
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 |
Device sessions Device 1: Device 2: |
10. test_community_message_edit, id: 702843 |
Device sessions Device 1: Device 2: |
11. test_community_unread_messages_badge, id: 702841 |
Device sessions Device 1: Device 2: |
1. test_add_contact_field_validation, id: 702777 |
Device sessions Device 1: Device 2: |
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 |
Device sessions Device 1: Device 2: |
3. test_activity_center_contact_request_decline, id: 702850 |
Device sessions Device 1: Device 2: |
1. test_links_open_universal_links_from_chat, id: 704613 |
Device sessions Device 1: |
2. test_links_deep_links, id: 702775 |
Device sessions Device 1: |
1. test_wallet_add_remove_regular_account, id: 727231 |
Device sessions Device 1: |
2. test_wallet_add_remove_watch_only_account, id: 727232 |
Device sessions Device 1: |
1. test_1_1_chat_text_message_delete_push_disappear, id: 702733 |
Device sessions Device 1: Device 2: |
2. test_1_1_chat_push_emoji, id: 702813 |
Device sessions Device 1: Device 2: |
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
Device sessions Device 1: Device 2: |
4. test_1_1_chat_edit_message, id: 702855 |
Device sessions Device 1: Device 2: |
5. test_1_1_chat_pin_messages, id: 702731 |
Device sessions Device 1: Device 2: |
6. test_1_1_chat_message_reaction, id: 702730 |
Device sessions Device 1: Device 2: |
1. test_community_markdown_support, id: 702809 |
Device sessions Device 1: Device 2: |
2. test_community_hashtag_links_to_community_channels, id: 702948 |
Device sessions Device 1: Device 2: |
3. test_community_mentions_push_notification, id: 702786 |
Device sessions Device 1: Device 2: |
4. test_community_leave, id: 702845 |
Device sessions Device 1: Device 2: |
5. test_community_join_when_node_owner_offline, id: 703629 |
Device sessions Device 1: Device 2: |
Total executed tests: 5
Failed tests: 3
Expected to fail tests: 0
Passed tests: 2
IDs of failed tests: 727230,703391,727229
1. test_wallet_send_asset_from_drawer, id: 727230 |
``` critical/test_wallet.py:123: in test_wallet_send_asset_from_drawer self.wallet_1.send_asset_from_drawer(address=self.receiver['address'], asset_name='Ether', ../views/wallet_view.py:104: in send_asset_from_drawer self.address_text_input.send_keys(address) ../views/base_element.py:377: in send_keys self.find_element().send_keys(value) ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: EditBox by accessibility id: `address-text-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception ``` |
2. test_wallet_send_eth, id: 727229 |
``` critical/test_wallet.py:112: in test_wallet_send_eth self._check_balances_after_tx(amount_to_send, sender_balance, receiver_balance, eth_amount_sender, critical/test_wallet.py:98: in _check_balances_after_tx self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Eth amount in the receivers wallet is 0.0333 but should be 0.0334 E Eth amount in the senders wallet is 0.0374 but should be 0.0373 ``` |
1. test_1_1_chat_send_image_save_and_share, id: 703391 |
``` critical/chats/test_1_1_public_chats.py:458: in test_1_1_chat_send_image_save_and_share self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Not expected image is shown to the receiver. ``` Device sessions Device 1: Device 2: |
1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 |
Device sessions Device 1: Device 2: |
1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 |
Device sessions Device 1: Device 2: |
Hi @codemaster115, thanks for the PR!
Could you please clarify one moment that is not entirely clear from the PR description: does this PR completely fix the issue https://github.com/status-im/status-mobile/issues/19181 or only Wrong dark overlay color
?
The thing is that once this PR is merged, the entire issue will be closed, which will be wrong since there are several more comments from the designers besides the wrong overlay color. In this case please update the PR description or/and the issue accordingly. Thank you!
Hi @codemaster115, thanks for the PR! Could you please clarify one moment that is not entirely clear from the PR description: does this PR completely fix the issue #19181 or only
Wrong dark overlay color
?The thing is that once this PR is merged, the entire issue will be closed, which will be wrong since there are several more comments from the designers besides the wrong overlay color. In this case please update the PR description or/and the issue accordingly. Thank you!
@qoqobolo I just updated the PR description that it completely resolved the issue.
Thank you @codemaster115 ! I smoke-tested it, and everything looks good. E2e failures are not PR-related. I also think manual testing could be skipped in this PR according to the new process (please read it if you havenβt already: https://github.com/status-im/status-mobile/blob/develop/doc/pipeline_process.md)
So, the PR is ready for design review, @Francesca-G please check the fixes from your perspective, thank you! πβ¨
Overlay color looks much better, nice job β¨
About the tag: please make sure the text and the icon are in Success/Solid/50 so they're readable as per design:
(implementation on the left, design on the right)
@Francesca-G Please review it again. Just fixed
fixes #19181
Summary
Shell - notification screen issue
Platforms
Areas that maybe impacted
Functional
Steps to test
Before and after screenshots comparison
status: ready