Open xAlisher opened 1 month ago
After discussing this issue with John it needs to be updated. Hold on...
put the label "blocked" when it is under the discussion
Issue discussed with John and updated.
cc @J-Son89 should it be included in 2.30?
It does seem like something worth having, let's put it lower priority than the high
priority bugs, but once we get through them we can look at it? wdyt? 🤔
Yes, I think it is required feature to be honest, agreed
User Story
As a Status app user, I want to be able to scan Metamask QR addresses, so I can send assets or save the address, if Status supports the network.
Description
Metamask stores addresses in QR codes with the following format: ethereum:0x38cf6E0Ba4C4530735616e1Ee7ff5FbCB726fBd2@0xa
ethereum: - prefix described in EIP-67 0xa - chain ID suffix described in EIP-155
Since Status addresses do not include these parts, we need to convert the data from Metamask QR addresses to a format our app can work with for sending, saving, and editing network preferences.
Conversion
ethereum: - prefix should be ignored and removed on our side
Status addresses follow the EIP-3770 format, which maps hexadecimal chain IDs to readable chain prefixes.
More networks: chains_mini.json file on chainid.network
After converting, ethereum:0x38cf6E0Ba4C4530735616e1Ee7ff5FbCB726fBd2@0xa should become oeth:0x38cf6E0Ba4C4530735616e1Ee7ff5FbCB726fBd2
This conversion should happen in all instances of scanning addresses, such as
It should be implemented on all supported platforms.
If the address contains an unsupported network, the user should receive an error "Address contains unsupported network" Users should not be able to save addresses with unsupported network prefixes to avoid problems in the send flow and sending assets to wrong networks.
Implementation.
Acceptance Criteria
Future Steps Consider supporting Metamask's "Payment request" QR format including additional data like requested amount and token ID.