status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.88k stars 984 forks source link

Multicollectibles are shown as single collectibles in the wallet and leading to sending flow related to ERC-721 collectibles #20065

Open VolodLytvynenko opened 3 months ago

VolodLytvynenko commented 3 months ago

Description:

We have a test user, link, who has some collectibles that are correctly shown in OpenSea as a multi-collectible type, with the number of how many collectibles are owned But multicollectibles which are related to Ethereum or Arbitrium networks are shown as single collectibles in the wallet instead of being recognized and displayed as multicollectibles, leading to a single collectible sending flow instead of the multi-collectible flow.

here are some multi collectibles examples that are correctly shown in OpenSea: image

Steps:

  1. Restore the user with multicollectibles on mainnet, mainnet arbitrium, sepolia, or sepolia arbitrium, or add the address (0xfc6327a092f6232e158a0dd1d6d967a2e1c65cd5) as watch only
  2. Check the multicollectibles related to the specified networks.

Actual result:

Multicollectibles of Ethereum and Optimism networks are shown as single collectibles. image

Expected result:

Multicollectibles are recognized and displayed as multicollectibles, enabling the multicollectible sendingflow image

NOTE:

The collectibles on the optimism work correctly and recognized as multi collectible

ENV:

NIghtly 16 May 2024

J-Son89 commented 3 months ago

@BalogunofAfrica - perhaps you know how to handle this one? 🤔

BalogunofAfrica commented 3 months ago

@BalogunofAfrica - perhaps you know how to handle this one? 🤔

Would check it out

BalogunofAfrica commented 3 months ago

Hi @VolodLytvynenko, it is displayed as multicollectibles in latest develop:

Simulator Screen Recording - iPhone 11 Pro - 2024-05-20 at 19 16 34

Also, the send flow for multicollectibles was added here: https://github.com/status-im/status-mobile/pull/20045

VolodLytvynenko commented 3 months ago

Hi @VolodLytvynenko, it is displayed as multicollectibles in latest develop:

Simulator Screen Recording - iPhone 11 Pro - 2024-05-20 at 19 16 34 Simulator Screen Recording - iPhone 11 Pro - 2024-05-20 at 19 16 34

Also, the send flow for multicollectibles was added here: #20045

hi @BalogunofAfrica, this is weird. I'm using this evening 5/27. To me, collectibles are not presented as multi-collectibles. Perhaps the logs will help understand what's going on.

https://github.com/status-im/status-mobile/assets/52490791/47ead625-8c5d-4384-aece-b81b00cf745e

OS:

IOS, Android

Devices:

Logs

Status-debug-logs.zip

VolodLytvynenko commented 2 months ago

@BalogunofAfrica This issue is reproducible on the desktop as well. Here are the collectibles, which are shown as a single collectible for this 0xfc6327a092f6232e158a0dd1d6d967a2e1c65cd5 address.

image

https://opensea.io/assets/ethereum/0xa342f5d851e866e18ff98f351f2c6637f4478db5/93539746106169265185984122850742147987924040810729814653747710597909889193997

https://opensea.io/assets/arbitrum/0x990eb28e378659b93a29d46ff41f08dc6316dd98/10000

Expected result:

how collectibles are shown for user in opensea image

churik commented 1 month ago

postponed due to limited capacity