Open ilmotta opened 2 weeks ago
Stuck at the event below after scanning qr code at https://react-app.walletconnect.com/, no on-success or on-fail
(rf/reg-event-fx
:wallet-connect/pair
(fn [{:keys [db]} [url]]
(let [web3-wallet (get db :wallet-connect/web3-wallet)]
{:fx [[(log/spy :info :effects.wallet-connect/pair)
{:web3-wallet web3-wallet
:url (log/spy :info url)
:on-fail #(log/error (log/spy :info "Failed to pair with dApp") {:error %})
:on-success #(log/info (log/spy :info "dApp paired successfully"))}]]})))
Network issue solved
Updates:
Next up:
wallet-connect proposer has dapp icons
"proposer": {
"publicKey": "...",
"metadata": {
"description": "React App for WalletConnect",
"url": "https://react-app.walletconnect.com",
"icons": [
"https://avatars.githubusercontent.com/u/37784886"
],
"name": "React App"
}
}
where to get dapp logo, do we have it persisted in mobile db already? How to identify dapp between mobile and go without relying on wallet connect?
We are persisting the dapps data (including the icon) when connecting in services/walletconnect/walletconnect.go
.
Figma uses token context tag for dapp, but dapp log is not always a token logo
Not sure I follow. Is it that figma designs expect a token
type and don't have a dapp
type? If so, I guess we would need to add an extra type to the context tag (and update the design system as well).
Feature
Figma reference: https://www.figma.com/design/JZqS95JKcpZU13NHbJ9qVT/dApp-Interactions?node-id=47-30832&t=71hDvlz63qdheZ2z-0
Notes
Out of scope
Pressing on the notification to execute its default action will be a separate GH issue.
Resources
Status > wallet > #wallet-connect
dApp Interactions > Notifications
with all combinations of notifications and their triggering conditions https://www.figma.com/design/JZqS95JKcpZU13NHbJ9qVT/dApp-Interactions?node-id=402-79057&t=BGzrkR6RbveKRIRj-0