status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.85k stars 983 forks source link

Crash when trying to attach image to message #20510

Open igor-sirotin opened 1 week ago

igor-sirotin commented 1 week ago

Problem

Reproduce steps:

  1. Go to Status Community -> #mobile
  2. Press "attach image" button

https://github.com/status-im/status-mobile/assets/25482501/43137227-21c5-4ee9-afd9-5940813d28a8

Acceptance Criteria

No crash. Able to attach an image.

Info

Device: iPhone 14 Pro OS: iOS 17.5.1

App version: 2.29.20425 (20240617141826) App commit: c20a2da267973f7403655fe4524dfc9bd4a8fbcd Node version: StatusIM/v0.180.30/ios-arm64/go1.21.8

ilmotta commented 1 week ago

For anyone going to investigate this issue, I couldn't reproduce on Android 13 on a real device and when pointing to the revision reported in this issue c20a2da267973f7403655fe4524dfc9bd4a8fbcd. Possibly an iOS-only bug.

@status-im/mobile-qa, whenever possible, could you check if you can reproduce this bug in other devices or is it only affecting this particular version of iOS?

pavloburykh commented 1 week ago

Hey @ilmotta! Not reproducing on my iPhone X, IOS 16.7.7

VolodLytvynenko commented 1 week ago

Hi. Can't reproduce it on iPhone 11 Pro max, IOS 17.5

https://github.com/status-im/status-mobile/assets/52490791/aa399fdc-444b-4b06-a834-899af023b9a6

mariia-skrypnyk commented 1 week ago

Hey hey @ilmotta !

Did the exact steps on nightly and no crash. Tried on my iPhone 13 (17.5.1).

igor-sirotin commented 1 week ago

Thanks you for checking! I'm still able to reproduce it every time. Let me know if I should gather any details for you. I guess I can get a crash dump somehow?

qoqobolo commented 1 week ago

Hey @igor-sirotin, thanks for reporting! Do you have your mobile app synced with desktop?

igor-sirotin commented 1 week ago

I tried to limit photos access to 1 image and it's working. Also doesn't crash with no photo access.

But still crashes when going back to Full access to my 9k photos and 1,5k videos.

igor-sirotin commented 1 week ago

Hey @igor-sirotin, thanks for reporting! Do you have your mobile app synced with desktop?

yes 🙂 But it doesn't seem related in any way

qoqobolo commented 1 week ago

Hey @igor-sirotin, thanks for reporting! Do you have your mobile app synced with desktop?

yes 🙂 But it doesn't seem related in any way

yeah I see now it's most likely related to permissions/some specific media in your gallery 👌

churik commented 6 days ago

for the record, also not reproducible for me Device: iPhone 14 Pro OS: iOS 17.5.1 IMAGE 2024-06-24 17:02:55

I put low-prioso far, as no clue how to get the issue

igor-sirotin commented 6 days ago

lol, what is it in my photo library 😄

ilmotta commented 6 days ago

@igor-sirotin, let's give some more time for this issue to pop-up again from other users. I'm sorry to see we can't help yet.

The only other idea I can think of now is if you tried to develop the mobile app against your real device to better debug the error, but that's a whole lot to digest 😄 But if you want to venture yourself in the darkness of status-mobile let us know and we can try to help.

igor-sirotin commented 6 days ago

let's give some more time for this issue to pop-up again from other users. I'm sorry to see we can't help yet.

The only other idea I can think of now is if you tried to develop the mobile app against your real device to better debug the error, but that's a whole lot to digest 😄 But if you want to venture yourself in the darkness of status-mobile let us know and we can try to help.

@ilmotta, no worries, thank you! I'll be ready to debug this at some point later 🙂

flexsurfer commented 4 days ago

we are loading images with

[rn/image
      {:source {:uri (:uri item)}
       :style  (style/image window-width index)}]
   so most likely something wrong with the image, corrupt or something? not supported format might be
flexsurfer commented 4 days ago

hey @igor-sirotin please try this one https://github.com/status-im/status-mobile/pull/20574

flexsurfer commented 4 days ago

thanks Igor, so now we know it's not the image rendering, the error happens in the second request for cameraroll/get-photos