status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum

https://status.app

Mozilla Public License 2.0

3.89k stars 985 forks source link

ENS name not applied after local pairing the account from status-desktop #20511

Closed igor-sirotin closed 1 month ago

igor-sirotin commented 3 months ago

Problem

I use sirotin.eth ENS name with my account in status-desktop. I used local pairing to pair this account with mobile app.

After pairing, my display name on mobile is sirotin.eth. But

the identicon ring is there
I'm able to edit the display name, as it wouldn't be an ENS name

But I see that there is ENS support in general. ducheng.eth doesn't have an identicon ring:

App info

App version: 2.29.20425 (20240617141826) App commit: c20a2da267973f7403655fe4524dfc9bd4a8fbcd Node version: StatusIM/v0.180.30/ios-arm64/go1.21.8

churik commented 3 months ago

I'm adding it to 2.30, would be nice to fix it, as I see from the channels that users do use ENS names and the only way to set it fro mobile is actually through sync in desktop or after upgrade from v1. So basically every user with ENS will see this behavior.

cc @ilmotta

ilmotta commented 3 months ago

That's correct @churik, we haven't implemented ENS registration and name management, so ENS is only available through syncing from desktop. I take the important bug to fix from this issue is to disable users from editing their names when it's an ENS, is that correct? The other bug about the ring is harmless for 2.30 and seems fine to ignore in case no mobile dev can fix this in time.

churik commented 3 months ago

yes, agreed! Thank you!

churik commented 2 months ago

postponed due to limited capacity for 2.30