status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.89k stars 984 forks source link

In the fee section is not shown how much fiat is short to cover the gas fee #20560

Open VolodLytvynenko opened 3 months ago

VolodLytvynenko commented 3 months ago

Steps:

  1. Go to the routes generation page
  2. Disable 2 networks (NOTE: This step is necessary because currently, we can only generate the fee if the entered amount is available on a single enabled network.)
  3. Enter a value close to the maximum available if ETH is used, or enter a value in a non-ETH token when ETH assets are not available to cover the gas fee.

Actual result:

Expected result:

The fee is highlighted in red image https://www.figma.com/design/xLs1KYmF4e6WwRTZVJKeUK/Descoped-Wallet?node-id=15329-122613&t=IkBLWZnxdyOqwZLn-0

ENV:

25 Jun 2024

Note:

the same issue is on the desktop image

churik commented 3 weeks ago

does not make sense to start working on this one before the tx simplified flow

VolodLytvynenko commented 3 weeks ago

does not make sense to start working on this one before the tx simplified flow

Hey @churik , this feature also exists in the simplified flow: Figma link I believe this PR can now be taken into work. But the problem is the status go does not send to the client the fee when there aren’t enough assets to cover the transaction