status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.86k stars 984 forks source link

Remove hot reload while theme changing #20563

Closed Parveshdhull closed 6 days ago

Parveshdhull commented 2 weeks ago

Summary

For some reason we added hot-reload for debug builds while changing theme.

https://github.com/status-im/status-mobile/issues/19794#issuecomment-2084615572

Most probably we don't need that because release builds are working fine.

Whoever works on this try changing theme while app is open (better using system theme) to see if debug app works fine. Also test overlay, like bottom sheet while testing.

(Ignore status-bar colors, they maybe be broken)

ilmotta commented 2 weeks ago

@Parveshdhull, I'm not working on this issue, but since you asked for people to double-check I'm sharing what I got now: I did a few theme changes from within the app settings with the OS theme in light & dark mode, and all possible combinations, and I didn't see any regressions from removing the hot-reload call. Although I only checked in emulated Android and with API 33, so take it with a grain of salt.