search

status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.89k stars 984 forks source link

Ring is displayed even for contact with an ENS name set #20617

Open ilmotta opened 2 months ago

ilmotta commented 2 months ago

Bug Report

Problem

Rings should not be displayed on contacts with an ENS name set and also not shown for the currently logged account. The expected behavior is a feature to help users quickly differentiate contacts with ENS names because these names are more trustworthy than arbitrary alias/display names set by users.

Bug first reported in this issue https://github.com/status-im/status-mobile/issues/20511.

Expected behavior

The expected behavior is the same as in status-desktop, i.e. rings are not displayed on contacts with ENS name set and are not displayed in screens showing the currently logged account avatar.

Actual behavior

There are multiple places to check/fix for contacts with ENS names (possibly more):

Solution

Consider not duplicating conditionals/checks to decide if the ring should be displayed. Consider making this logic implicit for every avatar displayed because this business rule has no exception.

Reproduction

  1. Use an account with ENS name (has to be done in status-desktop and synced on mobile).
  2. Join a community.
  3. Check the avatar in a channel member list contains a ring.

Additional Information

churik commented 1 month ago

postponed due to limited capacity for 2.30