status-im / status-mobile

a free (libre) open source, mobile OS for Ethereum
https://status.app
Mozilla Public License 2.0
3.91k stars 984 forks source link

Validation doesn't work if an already added regular acc or duplicate watch-only acc is attempted to be added #20652

Open Horupa-Olena opened 4 months ago

Horupa-Olena commented 4 months ago

Bug Report

Problem

Reproduction

  1. Open wallet
  2. Click the button "Add"
  3. Choose the option "Add address to watch"
  4. Paste an already added regular acc

Expected behavior

A validation message should be shown, and the "Continue" button should not be active.

Actual behavior

The validation message is not shown, and the "Continue" button remains active, allowing progression to the next step.

https://github.com/status-im/status-mobile/assets/150926723/10c9bbba-e9aa-4a8e-b452-1c96a27f2883

Additional Information

ulisesmac commented 1 month ago

AFAIK, adding a watched address is under a feature flag (it used to work, btw), so does it make sense to solve this for 2.31? @shivekkhurana

churik commented 1 month ago

removed from milestone due to limited capacity and temp removed watch-only

mohsen-ghafouri commented 5 days ago

not a priority, removed assignee